Conversation
Contributor
afiune
commented
Mar 21, 2025
afiune
commented
Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
afiune
commented
Mar 21, 2025
| args["arn"] = llx.StringData(convert.ToString(project.Arn)) | ||
| args["description"] = llx.StringData(convert.ToString(project.Description)) | ||
| args["arn"] = llx.StringDataPtr(project.Arn) | ||
| args["description"] = llx.StringDataPtr(project.Description) |
Contributor
Author
There was a problem hiding this comment.
There are cases like this one where, we could use StringDataPtr() instead of StringData() but, I do not know the implications of that change since one SETs the field to an empty string and the other one doesn't set it, but returns a Nil data type.
I am on board to leave these as is and not use StringDataPtr() but I am open to suggestions.
Contributor
jaym
approved these changes
Apr 1, 2025
vjeffrey
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.