Conversation
Contributor
99efa02 to
449bc1f
Compare
This comment has been minimized.
This comment has been minimized.
1272f00 to
1a77fab
Compare
231eb2e to
2f03115
Compare
Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
2f03115 to
6566b40
Compare
Member
|
@afiune thank you |
Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
7924011 to
1a2db60
Compare
Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
jaym
reviewed
Apr 2, 2025
| matches[1], | ||
| parseInt(matches[2]), | ||
| ) | ||
| // if ip.Broadcast != matches[3] { |
jaym
reviewed
Apr 2, 2025
jaym
reviewed
Apr 2, 2025
Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
a1ca787 to
27a4041
Compare
jaym
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces a new resource to the
osprovider callednetwork, thisresource today gathers all the network interfaces from the system and additional
information about the interface like ip addresses (v4 and v6), subnet, gateway, the
status and flags of the interface, as well as the MAC address.
Data Collection Methods
The new
networkipackage has an entry point function calledInterfaces()thatreturns the list of interfaces in the system. The way this function work is by detecting
the operating system we are connected to, and based of that information, it runs multiple
detector functions to collect as much information from different sources:
In the future, we can add more of these to enhance the data we collect.
Testing
Ran tests agains all three operating systems we need to support.
macOS🍎Windows🪟Linux🐧amazonlinuxDebian