Skip to content

🐛 only inform on unsupported providers#5391

Merged
chris-rock merged 2 commits intomainfrom
dom/unsupported-provider
Mar 31, 2025
Merged

🐛 only inform on unsupported providers#5391
chris-rock merged 2 commits intomainfrom
dom/unsupported-provider

Conversation

@arlimus
Copy link
Copy Markdown
Member

@arlimus arlimus commented Mar 28, 2025

Fixes #5389

Instead of showing errors like in the issue above, we now show a simple message where fields are not supported:

asset: {
  cpes: unsupported platform
  kind: "api"
  build: ""
  version: ""
  platformMetadata: {}
  title: "AWS Account"
  annotations: {}
  purl: unsupported platform
  arch: ""
  labels: {}
  platform: "aws"
  vulnerabilityReport: unsupported platform
  runtime: "aws"
  ids: [
    0: "//platformid.api.mondoo.app/runtime/aws/accounts/162854405951"
    1: "arn:aws:sts::162854405951"
  ]
  name: "AWS Account 162854405951"
  fqdn: ""
  family: []
}

@arlimus arlimus marked this pull request as ready for review March 28, 2025 20:55
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 28, 2025

Test Results

3 630 tests  ±0   3 626 ✅ ±0   2m 16s ⏱️ +8s
  397 suites ±0       4 💤 ±0 
   30 files   ±0       0 ❌ ±0 

Results for commit 648d6e6. ± Comparison against base commit 5f0d342.

♻️ This comment has been updated with latest results.

arlimus added 2 commits March 28, 2025 15:59
Fixes #5389

Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
@arlimus arlimus force-pushed the dom/unsupported-provider branch from da1e698 to 648d6e6 Compare March 29, 2025 03:37
@arlimus arlimus requested a review from chris-rock March 31, 2025 19:50
@chris-rock chris-rock merged commit e900374 into main Mar 31, 2025
17 checks passed
@chris-rock chris-rock deleted the dom/unsupported-provider branch March 31, 2025 20:09
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 31, 2025
@scottford-io
Copy link
Copy Markdown
Contributor

🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve RPC Error Handling for Non-Vulnerability-Supported Platforms (e.g., Terraform, Cloud, SaaS)

3 participants