🐛 detect OpenSSH 9.9 and force Key Exchange Algorithms#5568
Merged
Conversation
Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
Contributor
Contributor
|
i tested this and it does work, even when openssh client does not on my computer |
Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
jaym
reviewed
May 22, 2025
| "time" | ||
|
|
||
| awsconf "github.com/aws/aws-sdk-go-v2/config" | ||
| "github.com/cockroachdb/errors" |
Contributor
There was a problem hiding this comment.
probably should just use "errors"
jaym
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenSSH 9.9 introduces hybrid post-quantum algorithms, and when users try to connect via SSH, they get a key signature compatibility issue, most likely due to the go package https://pkg.go.dev/golang.org/x/crypto/ssh not supporting it yet or misinterpreting it.
Note that, there is also a reported bug that recommends upgrading to OpenSSH 9.9p2 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1103392 so we recommend users to upgrade their servers to that version.
Regardless, this change introduces an extra step during an SSH connection that detects if the server's advertised key exchange methods include unsupported hybrid ones, and if so, we will force the key exchange algorithm to a compatible one.