✨ Add const block to codegen with LR type names.#5974
Merged
chris-rock merged 3 commits intomainfrom Oct 1, 2025
Merged
Conversation
Contributor
jaym
approved these changes
Sep 30, 2025
Signed-off-by: Vasil Sirakov <sirakov97@gmail.com>
Signed-off-by: Vasil Sirakov <sirakov97@gmail.com>
f3b1468 to
99ddaef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhances LR codegen to also generate a
constblock with a const corresponding to the name of each type in the LR file. Having a const to reference, e.g.ResourceSomeTypeinstead of manually typing outsome.typecan be useful in when creating a resource and is less error prone.Example (
core.lr):Going over all existing occurrences and making use of the consts is not high prio and can be done eventually.