Skip to content

🐛 Fix panic on attempts to use ref as a map value#6241

Merged
slntopp merged 2 commits intomainfrom
mik/fix-map-to-map-value
Dec 2, 2025
Merged

🐛 Fix panic on attempts to use ref as a map value#6241
slntopp merged 2 commits intomainfrom
mik/fix-map-to-map-value

Conversation

@slntopp
Copy link
Copy Markdown
Member

@slntopp slntopp commented Dec 1, 2025

Fixes #6217

This fix consists of two parts:

  1. Fixes compile-time map type handling (panic) by enforcing Any types for Refs
  2. Fixes further dereferencing issue by implementing converter for MapLike

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 1, 2025

Test Results

4 655 tests  +3   4 651 ✅ +3   2m 27s ⏱️ +8s
  415 suites ±0       4 💤 ±0 
   31 files   ±0       0 ❌ ±0 

Results for commit 2cca1b7. ± Comparison against base commit e15ba02.

♻️ This comment has been updated with latest results.

@slntopp slntopp marked this pull request as ready for review December 2, 2025 09:43
Comment thread llx/data_conversions.go
Type: typ,
Value: res,
}, 0, nil
case types.MapLike:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nice @slntopp , can we add some tests around this?

@slntopp slntopp merged commit efda694 into main Dec 2, 2025
17 checks passed
@slntopp slntopp deleted the mik/fix-map-to-map-value branch December 2, 2025 17:16
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic on MQL query

2 participants