✨ Add support for global filtering by AWS tags.#6258
Merged
VasilSirakov merged 3 commits intomainfrom Dec 4, 2025
Merged
Conversation
VasilSirakov
commented
Dec 4, 2025
| return res, nil | ||
| } | ||
|
|
||
| func (a *mqlAwsEc2) getEc2Instances(ctx context.Context, svc *ec2.Client, filters connection.DiscoveryFilters) ([]ec2types.Reservation, error) { |
Contributor
Author
There was a problem hiding this comment.
There is no reason to return a list of Reservation objects here because we only care about the underlying instances. Returning a list of Instance directly here simplifies things and allows us to enforce the client-side filters in the same function.
Contributor
preslavgerchev
approved these changes
Dec 4, 2025
Signed-off-by: Vasil Sirakov <sirakov97@gmail.com>
Signed-off-by: Vasil Sirakov <sirakov97@gmail.com>
Signed-off-by: Vasil Sirakov <sirakov97@gmail.com>
VasilSirakov
force-pushed
the
vasil/aws-global-filtering
branch
from
116d809 to
1e2d913
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR:
There are way more AWS resources to apply this to, but this can happen in multiple subsequent PRs.
Examples:
No filters (everything is matched):
Exclude
Created By: Mondootag (nothing is matched):Include
Created By: NotMondootag server-side (nothing is matched):Include
Created By: Mondootag server-side (all are matched):