Merged
Conversation
Contributor
Bajusz15
approved these changes
Dec 5, 2025
chris-rock
reviewed
Dec 5, 2025
| list := items.Value.([]any) | ||
| if len(list) == 0 { | ||
| return bind, 0, nil | ||
| list, ok := items.Value.([]any) |
Member
There was a problem hiding this comment.
Can we add a test to ensure we do not accidentally get a regression?
slntopp
force-pushed
the
mik/fix-panic-in-arraylike-resources
branch
from
cfe5826 to
cfec048
Compare
…urce (e.g. `users`) Example: `users.where(false).sample()`
Fixes #6196 map is expected to always return an explicit ArrayLike type, which isn't happening in the runtime if list value is empty
slntopp
force-pushed
the
mik/fix-panic-in-arraylike-resources
branch
from
cfec048 to
7bfb157
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
.sampleis called on a array-like resource (e.g.users)Example:
users.where(false).sample()map is expected to always return an explicit ArrayLike type, which isn't happening in the runtime if list value is empty