🧹 Improve discovery filters parsing in the AWS provider.

[VasilSirakov]

No description provided.

[czunker]

Do we need a defaultValue as a separate parameter?

I only see false which would be the default anyway.

[VasilSirakov]

You are right, we only need false as a default but I exposed it just to make the fn more generic. I can remove it if you think it's not worth it.

[czunker]

I don't know much about the AWS part.
Let's keep it.

[github-actions]

Test Results

4 697 tests  +13   4 693 ✅ +13   2m 34s ⏱️ +14s
  415 suites ± 0       4 💤 ± 0 
   31 files   ± 0       0 ❌ ± 0 

Results for commit b6d6ee8. ± Comparison against base commit 4a5a0aa.

This pull request removes 3 and adds 16 tests. Note that renamed tests count towards both.

go.mondoo.com/cnquery/v12/providers/aws/connection ‑ TestParseOptsToFilters
go.mondoo.com/cnquery/v12/providers/aws/connection ‑ TestParseOptsToFilters/all_opts_are_mapped_to_discovery_filters_correctly
go.mondoo.com/cnquery/v12/providers/aws/connection ‑ TestParseOptsToFilters/empty_opts_are_mapped_to_discovery_filters_correctly

go.mondoo.com/cnquery/v12/providers/aws/connection ‑ TestDiscoveryFiltersFromOpts
go.mondoo.com/cnquery/v12/providers/aws/connection ‑ TestDiscoveryFiltersFromOpts/all_opts_are_mapped_to_discovery_filters_correctly
go.mondoo.com/cnquery/v12/providers/aws/connection ‑ TestDiscoveryFiltersFromOpts/empty_opts_are_mapped_to_discovery_filters_correctly
go.mondoo.com/cnquery/v12/providers/aws/connection ‑ TestDiscoveryFiltersFromOpts/nil_opts_are_mapped_to_discovery_filter_correctly
go.mondoo.com/cnquery/v12/providers/aws/connection ‑ TestParseBoolOpt
go.mondoo.com/cnquery/v12/providers/aws/connection ‑ TestParseBoolOpt/parses_false_values_correctly
go.mondoo.com/cnquery/v12/providers/aws/connection ‑ TestParseBoolOpt/parses_true_values_correctly
go.mondoo.com/cnquery/v12/providers/aws/connection ‑ TestParseBoolOpt/returns_default_for_missing_key
go.mondoo.com/cnquery/v12/providers/aws/connection ‑ TestParseCsvSliceOpt
go.mondoo.com/cnquery/v12/providers/aws/connection ‑ TestParseCsvSliceOpt/parses_comma-separated_values_correctly
…