✨ Add support for operating_system/container asset parsing in cyclonedx sboms#6317
Merged
chris-rock merged 2 commits intomainfrom Dec 17, 2025
Merged
✨ Add support for operating_system/container asset parsing in cyclonedx sboms#6317chris-rock merged 2 commits intomainfrom
chris-rock merged 2 commits intomainfrom
Conversation
…dx sboms. Signed-off-by: Preslav <preslav@mondoo.com>
preslavgerchev
commented
Dec 17, 2025
|
|
||
| // if we have no generator info, fallback to trying tools. these are deprecated | ||
| // but might still be present | ||
| if sbom.Generator == nil && bom.Metadata.Tools.Tools != nil { |
Contributor
Author
There was a problem hiding this comment.
this is purely fallback in case the tools are present and we couldnt get a generator
Contributor
chris-rock
reviewed
Dec 17, 2025
Member
chris-rock
left a comment
chris-rock
left a comment
There was a problem hiding this comment.
Looks great @preslavgerchev Lets reduce the testdata to the specific parts we want to test.
Signed-off-by: Preslav <preslav@mondoo.com>
chris-rock
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that operating_system and container sboms get an improved platform/platform ids so that we can improve the asset detection