🧹 Reuse ec2TagsToMap and vpcFilter functions.#6329
Merged
chris-rock merged 3 commits intomainfrom Dec 22, 2025
Merged
Conversation
Signed-off-by: Vasil Sirakov <sirakov97@gmail.com>
Signed-off-by: Vasil Sirakov <sirakov97@gmail.com>
Contributor
Test Results4 703 tests 4 699 ✅ 2m 11s ⏱️ Results for commit e4cae17. ♻️ This comment has been updated with latest results. |
Signed-off-by: Vasil Sirakov <sirakov97@gmail.com>
VasilSirakov
changed the title
chris-rock
approved these changes
Dec 22, 2025
Member
chris-rock
left a comment
chris-rock
left a comment
There was a problem hiding this comment.
Nice cleanup @VasilSirakov
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already have a conversion for
map[string]string->map[string]anyand using allows us to delete one of the functions.