🐛 Apply ECS and ECR filters in general and not only during discovery.

[VasilSirakov]

These ECR/ECS filters were only being applied during discovery. This moves the filter evaluation at the API call level which makes sure it works in general without the --discover flag. This also allows us to remove some more legacy functions.

Output from a test run:

cnquery> aws.ecr.privateRepositories { images { * } }
DBG skipping ecr private image due to tag filters repository=vasil/testrepo tags=["latest"]
DBG finished query execution qrid=pMXEAtU4uJI=
DBG VMlGZugtMv/xdwgWLhX3vB+R4ISz9WJWSaUexK0uzPagiwaJlAbh0Of8J4lyxMmU5Ipd6OI7FrnApcoNVZQUag== finished
DBG graph has received all datapoints
aws.ecr.privateRepositories: [
  0: {
    images: []
  }
]

[github-actions]

Test Results

4 713 tests  +10   4 709 ✅ +10   2m 34s ⏱️ +25s
  415 suites ± 0       4 💤 ± 0 
   31 files   ± 0       0 ❌ ± 0 

Results for commit 4a7a94c. ± Comparison against base commit af93da8.

This pull request removes 2 and adds 12 tests. Note that renamed tests count towards both.

go.mondoo.com/cnquery/v12/providers/aws/connection ‑ TestMatchesExcludeTags/no_exclude_tags_matches
go.mondoo.com/cnquery/v12/providers/aws/resources ‑ TestFilters

go.mondoo.com/cnquery/v12/providers/aws/connection ‑ TestEcrMatchesExcludeTags
go.mondoo.com/cnquery/v12/providers/aws/connection ‑ TestEcrMatchesExcludeTags/exclude_tags_do_not_match
go.mondoo.com/cnquery/v12/providers/aws/connection ‑ TestEcrMatchesExcludeTags/exclude_tags_match
go.mondoo.com/cnquery/v12/providers/aws/connection ‑ TestEcrMatchesExcludeTags/no_exclude_tags_does_not_match
go.mondoo.com/cnquery/v12/providers/aws/connection ‑ TestEcrMatchesIncludeTags
go.mondoo.com/cnquery/v12/providers/aws/connection ‑ TestEcrMatchesIncludeTags/include_tags_do_not_match
go.mondoo.com/cnquery/v12/providers/aws/connection ‑ TestEcrMatchesIncludeTags/include_tags_match
go.mondoo.com/cnquery/v12/providers/aws/connection ‑ TestEcrMatchesIncludeTags/no_include_tags_matches
go.mondoo.com/cnquery/v12/providers/aws/connection ‑ TestEcsMatchesOnlyRunningContainers
go.mondoo.com/cnquery/v12/providers/aws/connection ‑ TestEcsMatchesOnlyRunningContainers/OnlyRunningContainers_is_false,_any_container_state_matches
…

♻️ This comment has been updated with latest results.

[chris-rock]

Thank you @VasilSirakov