Conversation
f357b1f to
90292ee
Compare
Comment updates to improve the generated docs Signed-off-by: Tim Smith <tsmith84@gmail.com>
90292ee to
f0a67a1
Compare
This comment has been minimized.
This comment has been minimized.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (1)oneshot To accept these unrecognized words as correct, you could run the following commands... in a clone of the git@github.com:mondoohq/cnquery.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/c635c2f3f714eec2fcf27b643a1919b9a811ef2e/apply.pl' |
perl - 'https://github.com/mondoohq/cnquery/actions/runs/21682387198/attempts/2' &&
git commit -m 'Update check-spelling metadata'Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionaryThis includes both expected items (178) from .github/actions/spelling/expect.txt and unrecognized words (1)
Consider adding them (in with:
extra_dictionaries: |
cspell:node/dict/node.txt
cspell:python/src/python/python-lib.txt
cspell:fullstack/dict/fullstack.txt
cspell:java/src/java-terms.txt
cspell:python/src/python/python.txtTo stop checking additional dictionaries, add (in check_extra_dictionaries: ""If the flagged items are false positivesIf items relate to a ...
|
There was a problem hiding this comment.
Pull request overview
This PR improves documentation comments across multiple provider resource definition files (.lr files). The changes enhance the clarity and completeness of generated documentation by adding examples, fixing typos, improving descriptions, and updating deprecation notices.
Changes:
- Updated deprecation notices to reference version 13.0 instead of 12.0
- Enhanced field descriptions with examples and clarifying details (e.g., enum values, configuration options)
- Fixed typos and improved grammar in documentation comments
- Standardized capitalization and formatting in comments
Reviewed changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| providers/vsphere/resources/vsphere.lr | Updated deprecation notice to version 13.0 and added enum values for VIB acceptance levels |
| providers/terraform/resources/terraform.lr | Fixed spacing in comment for module directory path |
| providers/os/resources/os.lr | Updated multiple deprecation notices to version 13.0, improved descriptions with examples (SSH keys, logging flags, service types, container states, etc.) |
| providers/opcua/resources/opcua.lr | Added example server states to clarify field values |
| providers/network/resources/network.lr | Enhanced DNS record rdata description with examples |
| providers/ms365/resources/ms365.lr | Improved descriptions throughout, including filter examples, user settings, authentication methods, and risk levels |
| providers/k8s/resources/k8s.lr | Capitalized "Environment variables" for consistency |
| providers/google-workspace/resources/google-workspace.lr | Fixed spacing in comment for user creation time |
| providers/github/resources/github.lr | Capitalized "URL" in release URL comment and improved webhook config description |
| providers/gcp/resources/gcp.lr | Standardized "Internal ID for this resource" comments, fixed typos, improved descriptions for Redis endpoints, instance metadata, scheduling options, and many other fields |
| providers/core/resources/core.lr | Improved CPE "other" field description |
| providers/cloudflare/resources/cloudflare.lr | Capitalized "ID" in resource ID comment |
| providers/azure/resources/azure.lr | Enhanced descriptions for batch pool properties, storage metrics, hosting environment fields, and fixed duplicate "Recommendation risk" comment |
| providers/aws/resources/aws.lr | Fixed typo in backup setting and improved CORS rule description |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // Log entry field paths that are denied access in this bucket | ||
| restrictedFields []string | ||
| // Amount of time for which logs will be retained by default, after which they're' automatically deleted | ||
| // Amount of time for which logs will be retained by default, after which they're automatically deleted |
There was a problem hiding this comment.
Extra apostrophe in "they're' automatically". This should be "they're automatically" (only one apostrophe after the 'e').
| package @defaults("name version") { | ||
| // May be initialized with the name only, in which case it will look up | ||
| // the package with the given name on the system. | ||
| // The package with the given name on the system. |
There was a problem hiding this comment.
Incorrect capitalization. The word "The" on line 622 should be lowercase "the" since it continues the sentence from line 621: "May be initialized with the name only, in which case it will look up the package with the given name on the system."
| // The package with the given name on the system. | |
| // the package with the given name on the system. |
VasilSirakov
left a comment
There was a problem hiding this comment.
We could start to enforce backticks in some places instead of single quotes depending on how we want it to look in the README.
|
Let me generate this and then see what we want to modify project wide. Easy enough to go either direction |
Comment updates to improve the generated docs