Skip to content

v13: Remove support for sunset MariaDB Azure service#6629

Merged
tas50 merged 2 commits intomainfrom
tas50/mariadb_v2
Mar 3, 2026
Merged

v13: Remove support for sunset MariaDB Azure service#6629
tas50 merged 2 commits intomainfrom
tas50/mariadb_v2

Conversation

@tas50
Copy link
Copy Markdown
Member

@tas50 tas50 commented Feb 14, 2026

@tas50 tas50 changed the title Remove support for sunset MariaDB Azure service v13: Remove support for sunset MariaDB Azure service Feb 14, 2026
@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 14, 2026

Test Results

5 209 tests  ±0   5 205 ✅ ±0   2m 2s ⏱️ +3s
  409 suites ±0       4 💤 ±0 
   31 files   ±0       0 ❌ ±0 

Results for commit 6fc2d08. ± Comparison against base commit 7151877.

♻️ This comment has been updated with latest results.

@arlimus arlimus force-pushed the v13 branch 2 times, most recently from 49890b5 to 3ee098f Compare February 16, 2026 09:49
@github-actions

This comment has been minimized.

@arlimus arlimus force-pushed the v13 branch 4 times, most recently from 9108734 to 833e14f Compare February 19, 2026 01:39
Base automatically changed from v13 to main February 19, 2026 06:41
@tas50 tas50 marked this pull request as ready for review February 21, 2026 08:38
@tas50 tas50 mentioned this pull request Feb 22, 2026
43 tasks
Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comprehensive removal of sunset Azure MariaDB service; minor whitespace issue in discovery.go

@tas50 tas50 force-pushed the tas50/mariadb_v2 branch from b80079f to b7f405e Compare March 2, 2026 20:46
Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Azure MariaDB resource removal is incomplete — leftover version entries will cause stale schema metadata.

Additional findings (file/line not in diff):

  • 🟡 providers/azure/resources/azure.lr.versions:471 — 20 MariaDB version entries remain in azure.lr.versions after the resource definitions were removed from azure.lr. These should be removed to keep the versions file in sync with the schema. Delete lines 471–490 (azure.subscription.mariaDb through azure.subscription.mariaDbService.subscriptionId).

Copy link
Copy Markdown
Member

@arlimus arlimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated for a while, thank you!

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@tas50 tas50 force-pushed the tas50/mariadb_v2 branch from b7f405e to 6fc2d08 Compare March 2, 2026 23:55
@mondoo-code-review mondoo-code-review bot dismissed their stale review March 2, 2026 23:55

Superseded by new review

Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra blank line removed and MariaDB version entries cleaned up as requested.

@tas50 tas50 merged commit b42bc7f into main Mar 3, 2026
22 checks passed
@tas50 tas50 deleted the tas50/mariadb_v2 branch March 3, 2026 01:56
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants