🐛 Fix ELB classic load balancer field alignment and filtering#6679
Merged
chris-rock merged 2 commits intomondoohq:mainfrom Feb 26, 2026
Merged
Conversation
9568dc7 to
656b100
Compare
656b100 to
5727dc4
Compare
chris-rock
approved these changes
Feb 26, 2026
Member
chris-rock
left a comment
There was a problem hiding this comment.
Thank you @LittleSalkin1806
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes several issues with classic (v1) ELB load balancers so they work the same way as v2 (ALB/NLB) load balancers.
What was wrong
availabilityZones,securityGroups,hostedZoneId, orvpcon a classic load balancer would fail with a type conversion error because those fields were never set during creation.--filters "tag:...", looking up security groups or VPCs could fail if those resources didn't match the tag filter, breaking the entire query.targetGroupsfield on classic LBs tried to call the v2 API, which doesn't recognize classic ARNs. Now it returns an empty list immediately.Changes
aws_elb.go: Added missing fields to classic LBs, removed duplicate appends, made SG/VPC resolution graceful, added early exit for non-ELB ARNs in init, added classic LB guard on targetGroups.discovery.go: Simplified region handling to usef.Region.Datadirectly.