Skip to content

✨ Add Intune device ID detection to Windows clients#6686

Merged
czunker merged 4 commits intomainfrom
czunker/intune
Mar 6, 2026
Merged

✨ Add Intune device ID detection to Windows clients#6686
czunker merged 4 commits intomainfrom
czunker/intune

Conversation

@czunker
Copy link
Copy Markdown
Contributor

@czunker czunker commented Feb 26, 2026

This finds the Intune device ID for Windows client systems and adds it to the platform metadata.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 26, 2026

Test Results

5 258 tests  +12   5 254 ✅ +12   2m 2s ⏱️ +3s
  410 suites ± 0       4 💤 ± 0 
   31 files   ± 0       0 ❌ ± 0 

Results for commit 054bedf. ± Comparison against base commit 64dbc1a.

♻️ This comment has been updated with latest results.

@chris-rock
Copy link
Copy Markdown
Member

/review

Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call ordering bug: Intune detection runs before Windows 11 title correction in the WMI fallback path, so Win 11 Multi-Session won't be detected there.

@czunker
Copy link
Copy Markdown
Contributor Author

czunker commented Mar 2, 2026

/review

@mondoo-code-review mondoo-code-review bot dismissed their stale review March 2, 2026 15:51

Superseded by new review

Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds Intune device ID detection for Windows client systems; clean implementation following existing codebase patterns.

czunker and others added 4 commits March 4, 2026 07:19
Signed-off-by: Christian Zunker <christian@mondoo.com>
Signed-off-by: Christian Zunker <christian@mondoo.com>
Call correctForWindows11 before detectIntuneDeviceID so that
Windows 11 Enterprise Multi-Session systems have the correct
title when the Intune check runs.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Tighten multi-session detection to also require "Multi-Session" in title,
and fix PowerShell splatting bug where a single package string was split
into individual characters.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@czunker
Copy link
Copy Markdown
Contributor Author

czunker commented Mar 4, 2026

/review

@czunker czunker marked this pull request as ready for review March 4, 2026 07:15
@AdamVB
Copy link
Copy Markdown

AdamVB commented Mar 4, 2026

@vjeffrey @czunker can we get this into the product metrics somehow? See how many of our customer compute assets have an intune ID?

@czunker
Copy link
Copy Markdown
Contributor Author

czunker commented Mar 6, 2026

@vjeffrey @czunker can we get this into the product metrics somehow? See how many of our customer compute assets have an intune ID?

We might be able to extend the existing metric about asset types:
policy/datalakes/db/productmetrics/asset_type.go

@czunker czunker merged commit 3fdce58 into main Mar 6, 2026
30 of 31 checks passed
@czunker czunker deleted the czunker/intune branch March 6, 2026 08:36
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants