Skip to content

🐛 (os): skip unresolved users in group.members #6850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SergioChan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🐛 (os): skip unresolved users in group.members #6850

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions providers/os/resources/group.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,13 +89,16 @@ func (x *mqlGroup) members() ([]any, error) {
return nil, err
}

res := make([]any, len(x.membersArr))
for i, name := range x.membersArr {
res := make([]any, 0, len(x.membersArr))
for _, name := range x.membersArr {
if name == "" {
continue
}
user, ok := users.usersByName[name]
if !ok {
Comment on lines 97 to 98
Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review Bot Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 suggestion — Silently dropping unresolved users makes debugging harder — callers won't know why a group appears to have fewer members than expected. Consider emitting a log.Warn (or log.Debug) when a non-empty name is skipped so operators have some breadcrumb.

if !ok {
	log.Warn().Str("group", x.GetName().Data).Str("user", name).Msg("skipping unresolved group member")
	continue
}

return nil, errors.New("cannot find user with name '" + name + "'")
continue
}
res[i] = user
res = append(res, user)
}

return res, nil
Expand Down
Loading