Skip to content

✨ Add SageMaker, Inspector findings, Shield DRT, Firehose destinations, and Org delegated admin resources#6879

Merged
tas50 merged 4 commits intomainfrom
tas50/more_aws_v5
Mar 14, 2026
Merged

✨ Add SageMaker, Inspector findings, Shield DRT, Firehose destinations, and Org delegated admin resources#6879
tas50 merged 4 commits intomainfrom
tas50/more_aws_v5

Conversation

@tas50
Copy link
Copy Markdown
Member

@tas50 tas50 commented Mar 11, 2026

Summary

  • SageMaker: Add models, training jobs, processing jobs, pipelines, and domains with lazy-loaded details and typed IAM role/VPC/KMS references
  • Inspector: Add findings resource with package vulnerability, network reachability, and code vulnerability sub-resources
  • Shield Advanced: Add DRT access configuration and emergency contacts
  • Kinesis Firehose: Replace destinations []dict with typed destination resources (S3, Redshift, Elasticsearch, OpenSearch, Splunk, HTTP endpoint) including CloudWatch logging and IAM role references
  • Organizations: Add delegated administrators and delegated services
  • IAM Access Analyzer: Add archived findings support
  • Config/EventBridge: Add typed iamRole() references (deprecating raw roleArn string fields)

Test plan

  • Build and install AWS provider (make providers/build/aws && make providers/install/aws)
  • Verify SageMaker resources: mql run aws -c "aws.sagemaker.models { name arn }"
  • Verify Inspector findings: mql run aws -c "aws.inspector.findings { title severity status }"
  • Verify Shield DRT access: mql run aws -c "aws.shield.drtAccess"
  • Verify Firehose destinations: mql run aws -c "aws.kinesis.firehoseDeliveryStreams { destinations { type } }"
  • Verify delegated admins: mql run aws -c "aws.account.organization.delegatedAdministrators { name email }"
  • Verify archived findings: mql run aws -c "aws.iam.accessAnalyzer.archivedFindings.length"
  • Verify config recorder iamRole: mql run aws -c "aws.config.recorders { iamRole }"

🤖 Generated with Claude Code

@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 11, 2026

Test Results

5 450 tests  ±0   5 446 ✅ ±0   2m 19s ⏱️ +21s
  412 suites ±0       4 💤 ±0 
   31 files   ±0       0 ❌ ±0 

Results for commit 91fecad. ± Comparison against base commit a6550ff.

♻️ This comment has been updated with latest results.

@tas50 tas50 force-pushed the tas50/more_aws_v5 branch 2 times, most recently from a84da55 to 1327ae7 Compare March 11, 2026 17:45
@github-actions

This comment has been minimized.

@tas50 tas50 force-pushed the tas50/more_aws_v5 branch 2 times, most recently from 9cb9286 to 3276742 Compare March 11, 2026 18:03
// Source configuration if the stream reads from a Kinesis data stream
source dict
// Destinations for the delivery stream
destinations []dict
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a brand new resource. Willing to accept this breaking change

@tas50 tas50 force-pushed the tas50/more_aws_v5 branch 2 times, most recently from 1de6fa4 to 1fabf98 Compare March 11, 2026 18:39
@tas50 tas50 changed the title Add more AWS resources ✨ Add SageMaker, Inspector findings, Shield DRT, Firehose destinations, and Org delegated admin resources Mar 12, 2026
@tas50 tas50 force-pushed the tas50/more_aws_v5 branch from 1fabf98 to 9a5b260 Compare March 12, 2026 03:20
@github-actions

This comment has been minimized.

tas50 and others added 2 commits March 13, 2026 18:43
Signed-off-by: Tim Smith <tsmith84@gmail.com>
Add finding ARN prefix to __id for packageVulnerability,
networkReachability, codeVulnerability, cvssScore, and
vulnerablePackage sub-resources to prevent cache key collisions
across different findings.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@tas50 tas50 force-pushed the tas50/more_aws_v5 branch from 9a5b260 to 3490e64 Compare March 14, 2026 01:44
@github-actions

This comment has been minimized.

@tas50 tas50 marked this pull request as ready for review March 14, 2026 01:53
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New SageMaker resources (models, training jobs, processing jobs, pipelines, domains) added with correct patterns.

Comment thread providers/aws/resources/aws_sagemaker.go Outdated
Comment thread providers/aws/resources/aws_sagemaker.go Outdated
…etails

Addresses PR review: use a.Region.Data consistently (like tags() and other
resources) instead of a separately cached internal region field.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds new SageMaker resource types (models, training jobs, processing jobs, pipelines, domains) following established codebase patterns with no correctness issues.

@tas50 tas50 merged commit 6d1e629 into main Mar 14, 2026
22 checks passed
@tas50 tas50 deleted the tas50/more_aws_v5 branch March 14, 2026 04:19
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant