🐛 Fix nil pointer dereferences in AWS CloudFront and ECS#6919
Merged
Conversation
CloudFront ListFunctions can return nil FunctionList when no functions exist, causing a panic. ECS DescribeTaskDefinition can return nil TaskDefinition, also causing a panic on ContainerDefinitions access. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![mondoo-code-review[bot]](https://avatars.githubusercontent.com/in/2834902?s=60&v=4){kind=small}
tas50
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ListFunctions: Added nil check forFunctionListresponse. When no CloudFront functions exist, the API returns a nilFunctionList, causing a panic when iterating.Itemsand checking.NextMarker.DescribeTaskDefinition: Added nil check forTaskDefinitionresponse. The API can return a nilTaskDefinition, causing a panic when iterating.ContainerDefinitions. A similar nil check already exists at line 673 for a different call site.Test plan
aws.cloudfront.functions— should return empty list, not panicaws.ecs.taskswhere a task definition has been deregistered — should handle gracefully, not panic🤖 Generated with Claude Code