🐛 Fix missing pagination in AWS DynamoDB, Config, ECS, Redshift, SageMaker#6920
Merged
🐛 Fix missing pagination in AWS DynamoDB, Config, ECS, Redshift, SageMaker#6920
Conversation
![mondoo-code-review[bot]](https://avatars.githubusercontent.com/in/2834902?s=60&v=4){kind=small}
Several AWS API calls were missing pagination loops, causing silent data loss for accounts exceeding the default page size: - DynamoDB: ListTables (>100 tables), ListGlobalTables, ListBackups - Config: DescribeConfigRules (>25 rules) - ECS: ListContainerInstances (>100 instances) - Redshift: DescribeClusterParameters - SageMaker: ListTags (>50 tags) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
tas50
force-pushed
the
tsmith/fix-aws-pagination
branch
from
59522e1 to
5dfb2d7
Compare
tas50
changed the title
Contributor
Test Results5 452 tests 5 448 ✅ 1m 57s ⏱️ Results for commit 5dfb2d7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ListTables(max 100/page),ListGlobalTables, and per-tableListBackups— all previously had "no pagination required" comments but actually do paginateNextTokenpagination toDescribeConfigRules(max 25/page)NextTokenpagination toListContainerInstances(max 100/page), collecting all ARNs before callingDescribeContainerInstancesMarkerpagination toDescribeClusterParametersNextTokenpagination toListTags(max 50/page)All of these were silently dropping results for accounts exceeding the default page size.
Test plan
go build ./providers/aws/...compiles cleanly🤖 Generated with Claude Code