🐛 Fix S3 bucket ARN validation for GovCloud and China partitions#6921
Merged
🐛 Fix S3 bucket ARN validation for GovCloud and China partitions#6921
Conversation
The ARN validation in initAwsS3Bucket used a hardcoded "arn:aws:s3:" prefix check which rejected valid ARNs from aws-us-gov and aws-cn partitions. Replace with proper arn.Parse() + service check. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![mondoo-code-review[bot]](https://avatars.githubusercontent.com/in/2834902?s=60&v=4){kind=small}
tas50
changed the title
tas50
changed the title
Contributor
Test Results5 459 tests 5 455 ✅ 2m 0s ⏱️ Results for commit 6191ddf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
arn:aws:s3:prefix check ininitAwsS3Bucketwith properarn.Parse()+ service validationarn:aws-us-gov:s3:::bucket) and China (arn:aws-cn:s3:::bucket) partition ARNsarnvariable toarnValto avoid conflict with thearnpackage importTest plan
TestS3BucketArnValidationcovering standard, GovCloud, China, wrong-service, non-ARN, and empty-string casesgo build ./providers/aws/...compiles cleanlygo test ./providers/aws/resources/ -run TestS3BucketArnValidationpassesmql run aws -c "aws.s3.buckets { arn }"🤖 Generated with Claude Code