🐛 Fix Macie custom data identifier detail fetch using wrong region#6922
Merged
🐛 Fix Macie custom data identifier detail fetch using wrong region#6922
Conversation
populateIdentifierDetails hardcoded us-east-1 when calling GetCustomDataIdentifier, but identifiers are listed per-region. Cache the region from the listing context and use it for detail fetches. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![mondoo-code-review[bot]](https://avatars.githubusercontent.com/in/2834902?s=60&v=4){kind=small}
tas50
changed the title
Contributor
Test Results5 452 tests 5 448 ✅ 1m 59s ⏱️ Results for commit dacd8b7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
populateIdentifierDetailshardcodedus-east-1when callingGetCustomDataIdentifier, but custom data identifiers are listed per-region viagetCustomDataIdentifiers. If an identifier was created in a different region (e.g.,eu-west-1), the detail fetch would fail or return wrong data.cacheRegionfield tomqlAwsMacieCustomDataIdentifierInternal, populated it during listing, and used it inpopulateIdentifierDetailsinstead of the hardcoded region.Test plan
mql run aws -c "aws.macie.customDataIdentifiers { id description regex keywords tags }"and verify detail fields are populated correctly for identifiers in all regions🤖 Generated with Claude Code