🐛 Fix Lambda function init lookup by name+region#6923
Merged
Conversation
initAwsLambdaFunction constructed a lookup ARN with an empty account ID, which never matched real function ARNs. Pass the connection's account ID to getLambdaArn so the constructed ARN matches correctly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![mondoo-code-review[bot]](https://avatars.githubusercontent.com/in/2834902?s=60&v=4){kind=small}
tas50
changed the title
Contributor
Test Results5 452 tests 5 448 ✅ 2m 9s ⏱️ Results for commit 11bf604. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initAwsLambdaFunctionconstructed a lookup ARN with an empty account ID when called withnameandregion(noarn), producing e.g.arn:aws:lambda:us-east-1::function:myFunc. This never matched real function ARNs which contain the account ID, so the lookup always returned "lambda function does not exist".runtime.Connection.(*connection.AwsConnection).AccountId()) and pass it togetLambdaArn, so the constructed ARN includes the correct account ID and matches properly.Test plan
make providers/build/aws && make providers/install/aws)mql run aws -c "aws.lambda.function(name: \"<function-name>\", region: \"<region>\")"and verify it resolves correctly instead of returning "lambda function does not exist"mql run aws -c "aws.lambda.function(arn: \"arn:aws:lambda:...\")"🤖 Generated with Claude Code