🐛 Fix wrong error variable returned in initAwsEc2Volume#6965
Merged
Conversation
GetVolumes() error was silently swallowed because the code returned a stale `err` from an earlier CreateResource call instead of `rawResources.Error`. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
![mondoo-code-review[bot]](https://avatars.githubusercontent.com/in/2834902?s=60&v=4){kind=small}
Contributor
Test Results5 481 tests 5 477 ✅ 2m 14s ⏱️ Results for commit 1bbd149. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initAwsEc2Volume(aws_ec2.go:1906) checksrawResources.Errorbut returns the staleerrvariable from a priorCreateResourcecall on line 1898GetVolumes(), making volume init failures invisibleTest plan
go vet ./providers/aws/...passesmake test/lintpasses🤖 Generated with Claude Code