Skip to content

🧹 generate correct copyright for lr files#7090

Merged
imilchev merged 3 commits intomainfrom
ivan/lr-copyright
Apr 2, 2026
Merged

🧹 generate correct copyright for lr files#7090
imilchev merged 3 commits intomainfrom
ivan/lr-copyright

Conversation

@imilchev
Copy link
Copy Markdown
Member

@imilchev imilchev commented Apr 2, 2026

No description provided.

Signed-off-by: Ivan Milchev <ivan@mondoo.com>
Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one of 32 generated .lr.go files has the updated copyright; the rest will be stale until regenerated.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Test Results

1 746 tests   - 4 015   1 742 ✅  - 4 015   54s ⏱️ - 1m 18s
   97 suites  -   330       1 💤  -     3 
    1 files    -    32       3 ❌ +    3 

For more details on these failures, see this check.

Results for commit f9710e4. ± Comparison against base commit 2151fe4.

This pull request removes 4015 tests.
go.mondoo.com/mql/v13/providers/ansible/play ‑ TestPlaybookDecoding
go.mondoo.com/mql/v13/providers/ansible/play ‑ TestPlaybookDecoding/load_default_playbook
go.mondoo.com/mql/v13/providers/ansible/play ‑ TestPlaybookDecoding/load_playbook_with_blocks_and_errors
go.mondoo.com/mql/v13/providers/ansible/play ‑ TestPlaybookDecoding/load_playbook_with_multiple_plays
go.mondoo.com/mql/v13/providers/ansible/play ‑ TestPlaybookDecoding/load_playbook_with_roles
go.mondoo.com/mql/v13/providers/ansible/play ‑ TestPlaybookDecoding/load_playbook_with_serial
go.mondoo.com/mql/v13/providers/ansible/play ‑ TestPlaybookDecoding/load_playbook_with_vars
go.mondoo.com/mql/v13/providers/ansible/play ‑ TestTaskDecoding
go.mondoo.com/mql/v13/providers/ansible/play ‑ TestTaskDecoding/load_task_with_blocks
go.mondoo.com/mql/v13/providers/ansible/play ‑ TestTaskDecoding/load_task_with_vars
…

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All generated files now carry the updated copyright header, addressing the previous review finding.

Signed-off-by: Ivan Milchev <ivan@mondoo.com>
@imilchev imilchev force-pushed the ivan/lr-copyright branch from f9710e4 to be3de11 Compare April 2, 2026 08:10
Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test assertion will fail because the header length constant was not updated to match the new longer copyright string.

Signed-off-by: Ivan Milchev <ivan@mondoo.com>
@mondoo-code-review mondoo-code-review bot dismissed their stale review April 2, 2026 08:13

Superseded by new review

Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test fix corrects assertion argument order and string length for copyright header check.

@imilchev imilchev merged commit 83e039d into main Apr 2, 2026
22 checks passed
@imilchev imilchev deleted the ivan/lr-copyright branch April 2, 2026 08:17
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant