Skip to content

✨ Publish provider schema.json to release bucket#7093

Merged
chris-rock merged 6 commits intomainfrom
feat/publish-provider-schema
Apr 2, 2026
Merged

✨ Publish provider schema.json to release bucket#7093
chris-rock merged 6 commits intomainfrom
feat/publish-provider-schema

Conversation

@chris-rock
Copy link
Copy Markdown
Member

@chris-rock chris-rock commented Apr 2, 2026

Summary

  • Publishes standalone schema.json and provider.json files to the GCS release bucket during provider releases
  • Files are published alongside the existing .tar.xz archives at providers/<name>/<version>/schema.json

Test plan

  • Verify provider release workflow publishes schema.json and provider.json to the versioned bucket path
  • Confirm files are accessible at https://releases.mondoo.com/providers/<name>/<version>/schema.json

🤖 Generated with Claude Code

Publish standalone schema.json and provider.json files alongside the
existing .tar.xz archives during provider releases. This enables
downstream consumers (MCP, Nexus) to fetch provider schemas directly
without downloading and extracting platform-specific archives.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New GCS uploads for provider schema files lack -m flag and -c flag used by adjacent commands.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New gsutil commands upload provider schema files but use a different source path pattern than the existing commands, which may cause failures.

The schema file uploads don't depend on the per-package loop variable,
so move them after the loop using matrix.provider and the version from
config.go directly.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schema publishing step has a potential issue with PROVIDER variable redefinition and missing skip_publish guard.

Keep all uploads together in the loop for consistency with the existing
pattern. The loop runs once per matrix job anyway.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@mondoo-code-review mondoo-code-review bot dismissed their stale review April 2, 2026 13:44

Superseded by new review

Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New GCS uploads for provider schema files look correct but lack error handling for missing files.

Copy schema and provider JSON files to the root dist/ directory in the
bundler script so the publish step uses dist/ for all artifacts.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provider schema and metadata JSON files are now published alongside release bundles.

Additional findings (file/line not in diff):

  • 🔵 scripts/provider_bundler.sh:172 — The SHA256SUMS file only covers *.xz files and won't include the newly copied _schema.json and _provider.json files. If consumers verify downloads against these checksums, the schema/provider files can't be validated. Consider adding them to the checksum (e.g., shasum -a 256 ${PROVIDER_NAME}_${PROVIDER_VERSION}_*.xz ${PROVIDER_NAME}_${PROVIDER_VERSION}_*.json > ...) or generating a separate checksum file for them.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@chris-rock chris-rock merged commit 86a4cbf into main Apr 2, 2026
10 checks passed
@chris-rock chris-rock deleted the feat/publish-provider-schema branch April 2, 2026 14:20
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant