🐛 device/windows: restore disk read-only state, not online state

[tas50]

Bug

connection/device/windows/device_manager.go:

if diskStatus.Readonly {
    err = d.setDiskReadonlyState(targetDrive.Index, false)
    if err != nil {
        return nil, err
    }
    d.diskSetToOnline = true   // BUG: should be d.diskSetToReadonly = true
    d.diskIndex = targetDrive.Index
}

The read-only branch records its action in diskSetToOnline instead of diskSetToReadonly. diskSetToReadonly is therefore never set to true anywhere, so UnmountAndClose never restores the disk's read-only protection — the disk is left writable after the scan. Worse, the spurious diskSetToOnline = true makes cleanup flip the online/offline state that was never changed.

Fix

Record the read-only change in diskSetToReadonly so cleanup re-applies it. (Windows-only code path; verified by build — no mock harness exists for the disk-management PowerShell calls.)

🤖 Generated with Claude Code

https://claude.ai/code/session_015U1ocAxfcBhVYi3f9JnyZZ

---

Generated by Claude Code

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[mondoo-code-review]

Fixes incorrect flag tracking so disk read-only state is properly restored on cleanup.

[github-actions]

Test Results

11 153 tests  ±0   11 146 ✅ ±0   3m 24s ⏱️ - 1m 56s
   545 suites ±0        7 💤 ±0 
    40 files   ±0        0 ❌ ±0 

Results for commit 2d62edf. ± Comparison against base commit a92a575.

♻️ This comment has been updated with latest results.