🐛 awsssmsession: return the process-kill error, not nil#8665
Open
tas50 wants to merge 1 commit into
Open
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
![mondoo-code-review[bot]](https://avatars.githubusercontent.com/in/2834902?s=60&v=4){kind=small}
tas50
force-pushed
the
claude/fix-ssm-session-kill-error
branch
from
0bab3c5 to
936f247
Compare
Contributor
tas50
force-pushed
the
claude/fix-ssm-session-kill-error
branch
3 times, most recently
from
4a1b93f to
c00b38d
Compare
On Close, when TerminateSession succeeded (err == nil) but the earlier process.Kill() failed, the code returned the nil `err` instead of `processerr`, hiding the kill failure and reporting a clean close while a session-manager-plugin subprocess may have leaked. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015U1ocAxfcBhVYi3f9JnyZZ
tas50
force-pushed
the
claude/fix-ssm-session-kill-error
branch
from
c00b38d to
56aa96c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
connection/ssh/awsssmsession/session_manager.go, on session close:When
TerminateSessionsucceeds (err == nil) but the earliera.process.Kill()failed, the function returns the nilerr, hiding the kill failure. A leakedsession-manager-pluginsubprocess is reported as a clean close.Fix
return processerr. (Verified by build; this close path has no mock harness.)🤖 Generated with Claude Code
https://claude.ai/code/session_015U1ocAxfcBhVYi3f9JnyZZ
Generated by Claude Code