Skip to content

Migrate mql workflows to arc runners and add PR concurrency#8716

Open
username-is-already-taken2 wants to merge 3 commits into
mainfrom
gary/migrate-to-arc
Open

Migrate mql workflows to arc runners and add PR concurrency#8716
username-is-already-taken2 wants to merge 3 commits into
mainfrom
gary/migrate-to-arc

Conversation

@username-is-already-taken2

Copy link
Copy Markdown
Contributor

Summary

This updates the mql workflows to continue the runner migration away from the old Default pool and adds concurrency protection to a few PR-oriented workflows that were missing it.

Changes

  • move goreleaser.yml from group: Default to group: arc-runners
  • move pr-test-generated-files.yaml from group: Default to group: arc-runners
  • move the go-test and go-test-integration jobs in pr-test-lint.yml from group: Default to group: arc-runners
  • add concurrency to:
    • pr-test-windows.yml
    • spell-check.yaml
    • xgrep.yaml

Notes

  • existing ubuntu-latest jobs were left unchanged
  • actions/setup-go cache settings were already cache: false where relevant
  • cla.yaml was intentionally left untouched for now because it uses pull_request_target / issue_comment and should be handled separately

@mondoo-code-review mondoo-code-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward migration from Default to arc-runners and addition of PR concurrency groups — looks good.

Signed-off-by: Gary <gary@mondoo.com>
Signed-off-by: Gary <gary@mondoo.com>

@mondoo-code-review mondoo-code-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward runner migration and concurrency additions; one minor gap in concurrency config.

go-test:
runs-on:
group: Default
group: arc-runners

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 suggestion — The other PR-triggered workflows (pr-test-windows, spell-check, xgrep) all gained a concurrency block, but this workflow (pr-test-lint) did not. Since it has two long-running jobs (go-test and go-test-integration, both with 120-minute timeouts), it would benefit the most from cancel-in-progress. Consider adding:

concurrency:
  group: pr-test-lint-${{ github.event.pull_request.number || github.ref }}
  cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}

@@ -22,7 +23,7 @@ jobs:
# Check if there is any dirty change for generated files
generated-files:
runs-on:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 suggestion — Same note: this workflow was migrated to arc-runners but no concurrency block was added, unlike the other PR workflows. Consider adding one for consistency and to avoid redundant runs.

TSIGN_ACCESS_TOKEN: ${{ steps.get_token.outputs.TSIGN_ACCESS_TOKEN }}
MAKE_LATEST: ${{ inputs.make-latest == false && 'false' || 'true' }}

- name: Install rpm tooling

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 suggestion — The rpm package is installed unconditionally every run. If the ARC runner image is under your control, consider baking rpm into the base image to save CI time. If not, this is fine as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant