Migrate mql workflows to arc runners and add PR concurrency#8716
Migrate mql workflows to arc runners and add PR concurrency#8716username-is-already-taken2 wants to merge 3 commits into
Conversation
Signed-off-by: Gary <gary@mondoo.com>
Signed-off-by: Gary <gary@mondoo.com>
Signed-off-by: Gary <gary@mondoo.com>
| go-test: | ||
| runs-on: | ||
| group: Default | ||
| group: arc-runners |
There was a problem hiding this comment.
🔵 suggestion — The other PR-triggered workflows (pr-test-windows, spell-check, xgrep) all gained a concurrency block, but this workflow (pr-test-lint) did not. Since it has two long-running jobs (go-test and go-test-integration, both with 120-minute timeouts), it would benefit the most from cancel-in-progress. Consider adding:
concurrency:
group: pr-test-lint-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}| @@ -22,7 +23,7 @@ jobs: | |||
| # Check if there is any dirty change for generated files | |||
| generated-files: | |||
| runs-on: | |||
There was a problem hiding this comment.
🔵 suggestion — Same note: this workflow was migrated to arc-runners but no concurrency block was added, unlike the other PR workflows. Consider adding one for consistency and to avoid redundant runs.
| TSIGN_ACCESS_TOKEN: ${{ steps.get_token.outputs.TSIGN_ACCESS_TOKEN }} | ||
| MAKE_LATEST: ${{ inputs.make-latest == false && 'false' || 'true' }} | ||
|
|
||
| - name: Install rpm tooling |
There was a problem hiding this comment.
🔵 suggestion — The rpm package is installed unconditionally every run. If the ARC runner image is under your control, consider baking rpm into the base image to save CI time. If not, this is fine as-is.
Summary
This updates the
mqlworkflows to continue the runner migration away from the oldDefaultpool and adds concurrency protection to a few PR-oriented workflows that were missing it.Changes
goreleaser.ymlfromgroup: Defaulttogroup: arc-runnerspr-test-generated-files.yamlfromgroup: Defaulttogroup: arc-runnersgo-testandgo-test-integrationjobs inpr-test-lint.ymlfromgroup: Defaulttogroup: arc-runnerspr-test-windows.ymlspell-check.yamlxgrep.yamlNotes
ubuntu-latestjobs were left unchangedactions/setup-gocache settings were alreadycache: falsewhere relevantcla.yamlwas intentionally left untouched for now because it usespull_request_target/issue_commentand should be handled separately