Added skip-publish to test workflow and refactored GPG signing#391
Merged
philipbalinov merged 6 commits intomainfrom Mar 4, 2026
Merged
Added skip-publish to test workflow and refactored GPG signing#391philipbalinov merged 6 commits intomainfrom
philipbalinov merged 6 commits intomainfrom
Conversation
…key expired Signed-off-by: Gary Bright <gary@mondoo.com>
… uploading artifacts to the workflow Signed-off-by: Gary Bright <gary@mondoo.com>
Signed-off-by: Gary Bright <gary@mondoo.com>
Signed-off-by: Gary Bright <gary@mondoo.com>
Signed-off-by: Gary Bright <gary@mondoo.com>
username-is-already-taken2
changed the title
philipbalinov
approved these changes
Mar 4, 2026
philipbalinov
approved these changes
Mar 4, 2026
Contributor
philipbalinov
left a comment
philipbalinov
left a comment
There was a problem hiding this comment.
LGTM, thank you @username-is-already-taken2
merging, perhaps we should separate all the GPG magic into its own action and reuse it, this look pretty similar to what we had in repobuilder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought the old action for setting up the GPG looked a bit smelly, so I removed it and went with tasks that we used for the other workflows that need gpg signing.
I added the ability to test the workflow without creating the release, I mirrored the same arg
skip-publishas we use in other workflows.I tested the workflow, that run can be seen here https://github.com/mondoohq/terraform-provider-mondoo/actions/runs/22664086630