Add scope_mrn to policy_assignment for org and platform support#415
Merged
Add scope_mrn to policy_assignment for org and platform support#415
Conversation
Deprecate space_id in favor of scope_mrn which accepts the full MRN of any scope (space, organization, or platform). The change is backwards compatible — existing space_id configurations continue to work with a deprecation warning. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jaym
force-pushed
the
jdm/platform-org-policy-assignment
branch
from
2e4c6e8 to
4a1e9b7
Compare
Contributor
Author
|
/review |
![mondoo-code-review[bot]](https://avatars.githubusercontent.com/in/2834902?s=60&v=4){kind=small}
Changing the scope of a policy assignment should destroy and recreate the resource to ensure policies are properly unassigned from the old scope and assigned to the new one. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Org-level policy assignment tests interfere when run in parallel across multiple Terraform versions since they share the same org. Use a dedicated space with scope_mrn instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scope_mrnfield tomondoo_policy_assignmentresource, allowing policy assignments to organizations and platforms (not just spaces)space_idwith a deprecation message directing users toscope_mrnspace_idconfigs continue to workTest plan
TestAccPolicyAssignmentResourcepasses (backwards compat withspace_id)TestAccPolicyAssignmentResourceWithScopeMrnpasses (org-scoped assignment)space_idandscope_mrnproduces a conflict errorgo build ./...compiles cleanlygo generate)🤖 Generated with Claude Code