flatpak: Change the branch to stable#4231
Conversation
|
github secret variable names: which barth will pgp encrypt for luigi (just as was done for the beta api key) |
|
Did you test all these changes and made sure everything still builds successfully? |
Not all, because it's very long to wait, but all detected problems/errors will be solved when this pr becomes not-draft. |
|
BTW, this was needed to build, I right now detected this was pushed. |
bbbe27b to
0ec2270
Compare
da8f0d9 to
b408729
Compare
|
I don't understand too much about this process but it seems to me that to make progress towards it is required to merge this pull request first. This is based on the following. Quote flathub/flathub#3905 (comment) me:
barthalion (avoiding potentially unnecessary ping by avoding to use
Therefore my question: Can this pull request be merged? |
I need to update some dependencies and test it, then yes |
|
I don't know what happened to the github runners but now it needs more time for aarch64. I think it's better to wait for the native aarch64 runners. |
|
have the new native runners changed anything for build times? @BigmenPixel0 |
|
@plowsof they are available for Github customers on paid plans, so I don't know yet but it must because qemu is much slower anyway |
c820c67 to
aa1f700
Compare
77d5605 to
19134ce
Compare
|
@adrelanos @plowsof |
| - type: archive | ||
| url: https://github.com/zeromq/libzmq/releases/download/v4.3.4/zeromq-4.3.4.tar.gz | ||
| sha256: c593001a89f5a85dd2ddf564805deb860e02471171b3f204944857336295c3e5 | ||
| url: https://github.com/zeromq/libzmq/releases/download/v4.3.5/zeromq-4.3.5.tar.gz |
| - type: archive | ||
| url: https://github.com/libusb/hidapi/archive/hidapi-0.13.1.tar.gz | ||
| sha256: 476a2c9a4dc7d1fc97dd223b84338dbea3809a84caea2dcd887d9778725490e3 | ||
| url: https://github.com/libusb/hidapi/archive/hidapi-0.14.0.tar.gz |
| - type: archive | ||
| url: https://github.com/libusb/libusb/releases/download/v1.0.26/libusb-1.0.26.tar.bz2 | ||
| sha256: 12ce7a61fc9854d1d2a1ffe095f7b5fac19ddba095c259e6067a46500381b5a5 | ||
| url: https://github.com/libusb/libusb/releases/download/v1.0.27/libusb-1.0.27.tar.bz2 |
| - type: archive | ||
| url: https://nlnetlabs.nl/downloads/unbound/unbound-1.17.1.tar.gz | ||
| sha256: ee4085cecce12584e600f3d814a28fa822dfaacec1f94c84bfd67f8a5571a5f4 | ||
| url: https://nlnetlabs.nl/downloads/unbound/unbound-1.22.0.tar.gz |
| - type: archive | ||
| url: https://boostorg.jfrog.io/artifactory/main/release/1.82.0/source/boost_1_82_0.tar.gz | ||
| sha256: 66a469b6e608a51f8347236f4912e27dc5c60c60d7d53ae9bfe4683316c6f04c | ||
| url: https://archives.boost.io/release/1.84.0/source/boost_1_84_0.tar.gz |
| - type: archive | ||
| url: https://github.com/libuv/libuv/archive/v1.44.2.tar.gz | ||
| sha256: e6e2ba8b4c349a4182a33370bb9be5e23c51b32efb9b9e209d0e8556b73a48da | ||
| url: https://github.com/libuv/libuv/archive/v1.50.0.tar.gz |
There was a problem hiding this comment.
can't find this in Dockerfile.linux
There was a problem hiding this comment.
can't find this in Dockerfile.linux
Yes, it's for p2pool
| tag: v4.4 | ||
| commit: f1c9a1f5052498b75de9c267d49bec7730889cb0 | ||
| post-install: |
There was a problem hiding this comment.
| tag: v4.4 | |
| commit: f1c9a1f5052498b75de9c267d49bec7730889cb0 | |
| post-install: | |
| tag: v4.12 | |
| commit: 0a15afb3ebd4ff3305c9f87276392b0084283624 | |
| post-install: |
|
|
||
| - name: Build flatpak | ||
| uses: flatpak/flatpak-github-actions/flatpak-builder@v6 | ||
| uses: flathub-infra/flatpak-github-actions/flatpak-builder@821846071bc503ec98c1db6b75530b571606e1a5 |
There was a problem hiding this comment.
why the change to flathub-infra? the example here still uses flatpak/.../@v6 https://github.com/flatpak/flatpak-github-actions?tab=readme-ov-file#multi-arch-build-using-public-arm64-runners
There was a problem hiding this comment.
why the change to flathub-infra? the example here still uses flatpak/.../@v6 https://github.com/flatpak/flatpak-github-actions?tab=readme-ov-file#multi-arch-build-using-public-arm64-runners
I don't remember well why I used it then, there were some reasons, but not anymore
There was a problem hiding this comment.
lets just update to what they use now for consistency
| runs-on: ${{ matrix.runner }} | ||
| container: | ||
| image: bilelmoussaoui/flatpak-github-actions:kde-5.15-22.08 | ||
| image: ghcr.io/flathub-infra/flatpak-github-actions:kde-5.15-24.08 |
There was a problem hiding this comment.
| image: ghcr.io/flathub-infra/flatpak-github-actions:kde-5.15-24.08 | |
| image: ghcr.io/flathub-infra/flatpak-github-actions:kde-5.15-25.08 |
595318d to
0556a22
Compare
|
|
It can be merged now (I verified the app) |
4e638f5 to
9e662eb
Compare
It can be pushed after Monero gets verified on Flathub and the stable token is added to the
FLATHUB_TOKENenvironment.Also, we need to wait for this.