Skip to content

flatpak: Change the branch to stable#4231

Open
q7nm wants to merge 1 commit intomonero-project:masterfrom
q7nm:switch-to-stable
Open

flatpak: Change the branch to stable#4231
q7nm wants to merge 1 commit intomonero-project:masterfrom
q7nm:switch-to-stable

Conversation

@q7nm
Copy link
Copy Markdown
Contributor

@q7nm q7nm commented Oct 21, 2023

It can be pushed after Monero gets verified on Flathub and the stable token is added to the FLATHUB_TOKEN environment. Also, we need to wait for this.

@plowsof
Copy link
Copy Markdown
Contributor

plowsof commented Oct 21, 2023

github secret variable names:
current beta token : FLATHUB_
proposed stable token name in this PR: FLATHUB_TOKEN

which barth will pgp encrypt for luigi (just as was done for the beta api key)

@selsta
Copy link
Copy Markdown
Collaborator

selsta commented Oct 21, 2023

Did you test all these changes and made sure everything still builds successfully?

@q7nm
Copy link
Copy Markdown
Contributor Author

q7nm commented Oct 21, 2023

Did you test all these changes and made sure everything still builds successfully?

Not all, because it's very long to wait, but all detected problems/errors will be solved when this pr becomes not-draft.

@q7nm
Copy link
Copy Markdown
Contributor Author

q7nm commented Oct 21, 2023

BTW, this was needed to build, I right now detected this was pushed.

@q7nm q7nm force-pushed the switch-to-stable branch from bbbe27b to 0ec2270 Compare October 22, 2023 09:38
@q7nm q7nm force-pushed the switch-to-stable branch 4 times, most recently from da8f0d9 to b408729 Compare April 3, 2024 14:26
@q7nm q7nm marked this pull request as ready for review April 3, 2024 14:35
@adrelanos
Copy link
Copy Markdown

I don't understand too much about this process but it seems to me that to make progress towards

it is required to merge this pull request first. This is based on the following. Quote flathub/flathub#3905 (comment)

me:

Is barthalion even still active?

Consider opening an issue at https://github.com/flathub/flathub to ask about this so maybe someone else from Flathub can reply and not waiting forever for a person that is no longer responsive?

barthalion (avoiding potentially unnecessary ping by avoding to use @):

Yes, I am. Maybe try to look around before producing another notification cluttering my inbox?

Unless the app gets verified and monero-project/monero-gui#4231 is merged, I don't think there's much to talk about right now.

Therefore my question: Can this pull request be merged?

@q7nm
Copy link
Copy Markdown
Contributor Author

q7nm commented Jul 9, 2024

Therefore my question: Can this pull request be merged?

I need to update some dependencies and test it, then yes

@q7nm q7nm force-pushed the switch-to-stable branch from b408729 to c820c67 Compare July 9, 2024 15:51
@q7nm
Copy link
Copy Markdown
Contributor Author

q7nm commented Jul 12, 2024

I don't know what happened to the github runners but now it needs more time for aarch64. I think it's better to wait for the native aarch64 runners.

@plowsof
Copy link
Copy Markdown
Contributor

plowsof commented Aug 30, 2024

have the new native runners changed anything for build times? @BigmenPixel0

@q7nm
Copy link
Copy Markdown
Contributor Author

q7nm commented Aug 31, 2024

@plowsof they are available for Github customers on paid plans, so I don't know yet but it must because qemu is much slower anyway

@q7nm q7nm force-pushed the switch-to-stable branch from c820c67 to aa1f700 Compare January 26, 2025 10:47
@q7nm
Copy link
Copy Markdown
Contributor Author

q7nm commented Jan 26, 2025

QEMU is dropped. With the new arm runner we can build flatpak much faster (< 1 hour).
Also, org.kde.Sdk should be updated to 5.15-24.08 but it seems there are some problems with the new gss for now (link)

@q7nm q7nm force-pushed the switch-to-stable branch 2 times, most recently from 77d5605 to 19134ce Compare March 17, 2025 15:33
@q7nm q7nm force-pushed the switch-to-stable branch from 19134ce to 595318d Compare April 1, 2025 09:03
@q7nm
Copy link
Copy Markdown
Contributor Author

q7nm commented Apr 1, 2025

@adrelanos @plowsof
I think it's ready now

Comment thread share/org.getmonero.Monero.yaml Outdated
- type: archive
url: https://github.com/zeromq/libzmq/releases/download/v4.3.4/zeromq-4.3.4.tar.gz
sha256: c593001a89f5a85dd2ddf564805deb860e02471171b3f204944857336295c3e5
url: https://github.com/zeromq/libzmq/releases/download/v4.3.5/zeromq-4.3.5.tar.gz
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RUN git clone -b v4.3.4 --depth 1 https://github.com/zeromq/libzmq && \

Comment thread share/org.getmonero.Monero.yaml Outdated
- type: archive
url: https://github.com/libusb/hidapi/archive/hidapi-0.13.1.tar.gz
sha256: 476a2c9a4dc7d1fc97dd223b84338dbea3809a84caea2dcd887d9778725490e3
url: https://github.com/libusb/hidapi/archive/hidapi-0.14.0.tar.gz
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RUN git clone -b hidapi-0.13.1 --depth 1 https://github.com/libusb/hidapi && \

could bump to 15 #4534

Comment thread share/org.getmonero.Monero.yaml Outdated
- type: archive
url: https://github.com/libusb/libusb/releases/download/v1.0.26/libusb-1.0.26.tar.bz2
sha256: 12ce7a61fc9854d1d2a1ffe095f7b5fac19ddba095c259e6067a46500381b5a5
url: https://github.com/libusb/libusb/releases/download/v1.0.27/libusb-1.0.27.tar.bz2
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RUN git clone -b v1.0.26 --depth 1 https://github.com/libusb/libusb && \

Comment thread share/org.getmonero.Monero.yaml Outdated
- type: archive
url: https://nlnetlabs.nl/downloads/unbound/unbound-1.17.1.tar.gz
sha256: ee4085cecce12584e600f3d814a28fa822dfaacec1f94c84bfd67f8a5571a5f4
url: https://nlnetlabs.nl/downloads/unbound/unbound-1.22.0.tar.gz
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RUN wget https://www.nlnetlabs.nl/downloads/unbound/unbound-1.16.2.tar.gz && \

Comment thread share/org.getmonero.Monero.yaml Outdated
- type: archive
url: https://boostorg.jfrog.io/artifactory/main/release/1.82.0/source/boost_1_82_0.tar.gz
sha256: 66a469b6e608a51f8347236f4912e27dc5c60c60d7d53ae9bfe4683316c6f04c
url: https://archives.boost.io/release/1.84.0/source/boost_1_84_0.tar.gz
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RUN wget https://archives.boost.io/release/1.80.0/source/boost_1_80_0.tar.gz && \

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RUN wget https://archives.boost.io/release/1.80.0/source/boost_1_80_0.tar.gz && \

The flatpak already uses 1.88.0. Maybe I should use the newer version if there are no problems with it (not only about this case)?

Comment thread share/org.getmonero.Monero.yaml Outdated
- type: archive
url: https://github.com/libuv/libuv/archive/v1.44.2.tar.gz
sha256: e6e2ba8b4c349a4182a33370bb9be5e23c51b32efb9b9e209d0e8556b73a48da
url: https://github.com/libuv/libuv/archive/v1.50.0.tar.gz
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't find this in Dockerfile.linux

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't find this in Dockerfile.linux

Yes, it's for p2pool

Comment thread share/org.getmonero.Monero.yaml Outdated
Comment on lines 103 to 105
tag: v4.4
commit: f1c9a1f5052498b75de9c267d49bec7730889cb0
post-install:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tag: v4.4
commit: f1c9a1f5052498b75de9c267d49bec7730889cb0
post-install:
tag: v4.12
commit: 0a15afb3ebd4ff3305c9f87276392b0084283624
post-install:

Comment thread .github/workflows/flatpak.yml Outdated

- name: Build flatpak
uses: flatpak/flatpak-github-actions/flatpak-builder@v6
uses: flathub-infra/flatpak-github-actions/flatpak-builder@821846071bc503ec98c1db6b75530b571606e1a5
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the change to flathub-infra? the example here still uses flatpak/.../@v6 https://github.com/flatpak/flatpak-github-actions?tab=readme-ov-file#multi-arch-build-using-public-arm64-runners

I don't remember well why I used it then, there were some reasons, but not anymore

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets just update to what they use now for consistency

Comment thread .github/workflows/flatpak.yml Outdated
runs-on: ${{ matrix.runner }}
container:
image: bilelmoussaoui/flatpak-github-actions:kde-5.15-22.08
image: ghcr.io/flathub-infra/flatpak-github-actions:kde-5.15-24.08
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
image: ghcr.io/flathub-infra/flatpak-github-actions:kde-5.15-24.08
image: ghcr.io/flathub-infra/flatpak-github-actions:kde-5.15-25.08

@q7nm
Copy link
Copy Markdown
Contributor Author

q7nm commented Dec 7, 2025

Built successfully
@plowsof

@plowsof
Copy link
Copy Markdown
Contributor

plowsof commented Jan 18, 2026

@q7nm
Copy link
Copy Markdown
Contributor Author

q7nm commented Jan 19, 2026

token added to https://www.getmonero.org/.well-known/org.flathub.VerifiedApps.txt

@plowsof, should I verify the app only after merging this pr?

@q7nm q7nm closed this Mar 22, 2026
@q7nm q7nm force-pushed the switch-to-stable branch from 0556a22 to 541c895 Compare March 22, 2026 08:29
@q7nm q7nm reopened this Mar 22, 2026
@q7nm
Copy link
Copy Markdown
Contributor Author

q7nm commented Mar 22, 2026

It can be merged now (I verified the app)

@q7nm q7nm force-pushed the switch-to-stable branch 2 times, most recently from 4e638f5 to 9e662eb Compare March 22, 2026 09:00
@q7nm q7nm force-pushed the switch-to-stable branch from 9e662eb to 0fca9ab Compare April 14, 2026 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants