CCS Monero Signer Resurrection (milestone 4). UR offline signing data exchange. To merge, monero #9492 needs to be merged first.#4358
Open
DiosDelRayo wants to merge 1 commit intomonero-project:masterfrom
Conversation
and needs to get enabled with `WITH_OTS_UR` to compile with UR. This update depends on [monero PR](monero-project/monero#9492). It cannot work without modifications on monero core! @tobtoht also mentions that build with static Qt5 will not work. I compiled and tested exclusively with ubuntu 24.04 in Qt Creator with Qt 5.15.2
sneurlax
reviewed
Sep 30, 2024
sneurlax
left a comment
sneurlax
left a comment
There was a problem hiding this comment.
Concept ACK, I reviewed the monero-project/monero changes but these are more extensive and I have less experience with monero-gui, so I will leave this for a reviewer with better subject area expertise. Let me know if a review is desperately needed and I'll wade through tho!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CAUTION: Do not merge before monero PR #9492 is merged!