Remove legacy pre-Jekyll PHP files#2632
Open
thomasbuilds wants to merge 1 commit intomonero-project:masterfrom
Open
Remove legacy pre-Jekyll PHP files#2632thomasbuilds wants to merge 1 commit intomonero-project:masterfrom
thomasbuilds wants to merge 1 commit intomonero-project:masterfrom
Conversation
language.php and _includes/language_cookie.php are remnants from the old PHP-based site. They are not executed by the current Jekyll/Netlify build, are not referenced from anywhere in the site, and redirect to a non-existent /home route. language.php also contains an unvalidated redirect built from the user-controlled MONERO_LANG cookie, which would be an open redirect if the file were ever served under a PHP interpreter (e.g. on a mirror).
✅ Deploy Preview for barolo-time-757cf9 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
language.php and _includes/language_cookie.php are remnants from the old PHP-based site. They are not executed by the current Jekyll/Netlify build, are not referenced from anywhere in the site, and redirect to a non-existent /home route.
language.php also contains an unvalidated redirect built from the user-controlled MONERO_LANG cookie, which would be an open redirect if the file were ever served under a PHP interpreter (e.g. on a mirror).