Skip to content

components/ui/dropdown/DropDown.astro: add name property to group dropdowns [beta] #2646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plowsof merged 1 commit into from
May 8, 2026
+11 −3
Merged

components/ui/dropdown/DropDown.astro: add name property to group dropdowns [beta] #2646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/components/pages/downloads/CoreCard.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ interface Props {
releaseNotesUrl?: string;
torrentUrl?: string;
magnetUrl?: string;
dropdownGroup?: string;
}

const {
Expand All @@ -47,6 +48,7 @@ const {
releaseNotesUrl,
torrentUrl,
magnetUrl,
dropdownGroup,
...rest
} = Astro.props;
const { t, safeMarkdown } = Astro.locals;
Expand Down Expand Up @@ -82,7 +84,10 @@ const PLATFORM_ICONS: Record<string, ImageMetadata> = {
</ul>
<div class="card-footer">
<div class="download-actions">
<Dropdown label={t("downloads:core.downloadButton")}>
<Dropdown
label={t("downloads:core.downloadButton")}
name={dropdownGroup}
>
{
downloads.map((item) =>
item === "separator" ? (
Expand Down
5 changes: 3 additions & 2 deletions src/components/ui/dropdown/Dropdown.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,12 @@ import { icons } from "@/utils/icons";

interface Props {
label?: string;
name?: string;
}
const { label } = Astro.props;
const { label, name } = Astro.props;
---

<details class="dropdown">
<details class="dropdown" name={name}>
<summary class="dropdown-summary">
<slot name="trigger">
<Button variant="primary" as="span">
Expand Down
2 changes: 2 additions & 0 deletions src/pages/downloads/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ const tabs = [
>,
)}
downloads={coreDownloads.gui.downloads as DownloadLink[]}
dropdownGroup="core-downloads"
/>

<!-- Monero CLI Card -->
Expand All @@ -90,6 +91,7 @@ const tabs = [
>,
)}
downloads={coreDownloads.cli.downloads as DownloadLink[]}
dropdownGroup="core-downloads"
/>
</Grid>

Expand Down
Loading