remove non determinism from deployed site files [beta] - #2654
Merged
Conversation
…ndomUUID defensive check if title is empty
passing id in all files where called
…terministic order
|
redsh4de
suggested changes
May 11, 2026
Comment on lines
+16
to
+24
| if (items?.some((i) => typeof i.title !== "string" || !i.title.trim())) { | ||
| throw new Error("<Accordion> item has an empty title."); | ||
| } | ||
| const accordionId = items?.length | ||
| ? `${variant}-${[...items.map((i) => i.title).join("")] | ||
| .slice(0, 7) | ||
| .map((c) => c.codePointAt(0)) | ||
| .join("-")}` | ||
| : `${variant}-slot`; |
Contributor
There was a problem hiding this comment.
Could add a stableId helper, smth like this that works with both strings & lists:
import { createHash } from "node:crypto";
export const stableId = (input: string | string[], length = 12): string => {
const data = typeof input === "string" ? input : JSON.stringify(input);
return createHash("sha256").update(data).digest("hex").slice(0, length);
};then can collapse to smth like this, and apply in NavItem, SectionTabs the same:
import { stableId } from "@/utils/stableId";
// ...
const titles = items?.map((i) => i.title) ?? [];
if (titles.some((t) => !t.trim())) {
throw new Error("<Accordion> item has an empty title.");
}
const accordionId = `${variant}-${titles.length ? stableId(titles) : "slot"}`
Collaborator
Author
There was a problem hiding this comment.
nice refactor , (although adding the import back), could PR it after this as i'd hate to back into diff hell / confirming what works
redsh4de
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2653
3 commits have small diffs, i built with everything, committed the dist folder, removed the commit and rebuilt, the file is the resulting diff
Accordian.astro-15864bcc.txt
index.astro-7c1dbd7b.txt
SectionTabs.astro-457800c3.txt