serialization: revert VA_ARGS_COMMAPREFIX usage
#10214
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffro256
force-pushed
the
va_args_revert
branch
from
1d84d06 to
a817da5
Compare
tobtoht
approved these changes
Nov 13, 2025
j-berman
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially revert #9287. The fallback for the
VA_ARGS_COMMAPREFIXmacro doesn't work, but the fallback is needed for GCC 7, since__VA_OPT__isn't supported until GCC 8.1. We still support GCC 7, so #9287 breaks the build on those platforms.Issue spotted by @j-berman when trying to build the Monero GUI against the
fcmp++-alpha-stressnetbranch in the Ubuntu 18 docker. The issue wasn't caught by CI since there's no analogue to #9287 merged to the release branch.