Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set response limits on http server connections [0.18] #9775

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Set response limits on http server connections [0.18] #9775

merged 2 commits into from
Feb 14, 2025
+429 −37

Conversation

vtnerd
Copy link
Contributor

@vtnerd vtnerd commented Feb 6, 2025

Same as #9765 but on release 0.18 branch. @selsta

@plowsof
Copy link
Contributor

plowsof commented Feb 6, 2025

build errors
/monero/contrib/epee/include/net/http_server_handlers_map2.h:110:24: error: ‘misc_utils’ has not been declared

@vtnerd vtnerd force-pushed the improve/rpc_threshold_0.18 branch 2 times, most recently from fcad5b0 to a2d574e Compare February 7, 2025 00:03
@vtnerd
Copy link
Contributor Author

vtnerd commented Feb 7, 2025

Yup. Sorry about that. I cherry picked a commit by @jeffro256 and included in this PR. The change is pretty simple, so I'm hoping reviewers won't turn away the additional changes (they are basically needed, or using namespace epee in the tests has to be added).

@vtnerd vtnerd force-pushed the improve/rpc_threshold_0.18 branch from a2d574e to d59374a Compare February 7, 2025 00:50
@vtnerd
Copy link
Contributor Author

vtnerd commented Feb 7, 2025

Another force push for a missing include. This compiles locally for me, so this may require several attempts at getting the CI to pass.

@vtnerd
Copy link
Contributor Author

vtnerd commented Feb 7, 2025

I forgot that #9687 hasn't been merged. Won't bother fixing the depends builds then.

@selsta selsta mentioned this pull request Feb 7, 2025
Open
8 tasks
@vtnerd vtnerd force-pushed the improve/rpc_threshold_0.18 branch from d59374a to 3137f33 Compare February 9, 2025 01:42
@vtnerd
Copy link
Contributor Author

vtnerd commented Feb 9, 2025

Force pushed changes to match those in master PR.

@nahuhh nahuhh mentioned this pull request Feb 10, 2025
Merged
@tobtoht
Copy link
Collaborator

tobtoht commented Feb 13, 2025

@vtnerd Please force push to rerun CI.

@vtnerd
epee: update 'http_server_handlers_map2.h' macros to use fully qualif…
89fa3ed 
…ied names

quick patch which fixes the issue where if you use some macros from `http_server_handlers_map2.h` you have to be in the `epee` namespace or it doesn't compile. Now can remove `using namespace epee;` from header file `core_rpc_server.h`, which caused a couple of name qualifying mistakes
@vtnerd vtnerd force-pushed the improve/rpc_threshold_0.18 branch from 3137f33 to 2c31c25 Compare February 13, 2025 21:37
@vtnerd
Copy link
Contributor Author

vtnerd commented Feb 13, 2025 •
edited
Loading

Force pushed rebase for CI.

@vtnerd vtnerd force-pushed the improve/rpc_threshold_0.18 branch from 2c31c25 to 13ff355 Compare February 14, 2025 05:23
@vtnerd
Copy link
Contributor Author

vtnerd commented Feb 14, 2025

Force pushed changes that were made to related master PR.

@tobtoht tobtoht merged commit 23a11d8 into monero-project:release-v0.18 Feb 14, 2025
16 checks passed
@vtnerd vtnerd deleted the improve/rpc_threshold_0.18 branch February 14, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selsta selsta selsta approved these changes

@SyntheticBird45 SyntheticBird45 SyntheticBird45 approved these changes

Assignees
No one assigned
Labels
networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vtnerd @plowsof @tobtoht @selsta @SyntheticBird45