Remedy some GCC warnings #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffro256
force-pushed
the
stringop-overflow
branch
from
5efdaa1 to
fd3db9f
Compare
|
Can you add closing #8 to your PR description? |
The `#ifdef SMALLTABLES` change eliminates the unused variable warning, and the changes to the sc25519_window4 prototype silences the `-Wstringop-overflow=` warnings in GCC. The prototype seems to be wrong b/c it requires an array of size 85, but the function definition only uses 64 bytes, the caller expects it only needs 64 bytes, and the 85 seems to be a copy/paste issue from window3 (Props to @moneromooo-monero for finding that) Resolves monero-project#8
jeffro256
force-pushed
the
stringop-overflow
branch
from
fd3db9f to
500f438
Compare
|
Sorry, #7 too :D And you can just change the PR description, you don't have to force push the patch description. |
Author
|
To explain the |
moneromooo-monero
approved these changes
May 28, 2022
Collaborator
|
These files are unmodified from the upstream version. So the only downside is that a diff of the directories will now report these files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
#ifdef SMALLTABLESchange eliminates the unused variable warning, and the changes to thesc25519_window4prototype silences the-Wstringop-overflow=warnings in GCC.The prototype seems to be wrong b/c it requires an array of size 85, but the function definition only uses 64 bytes, the caller expects it only needs 64 bytes, and the 85 seems to be a copy/paste issue from window3 (Props to @moneromooo-monero for finding that)
Closes #7 and #8