Skip to content

MON-4025 add caas split get transactions#164

Merged
ingridacero merged 1 commit into
mainfrom
MON-4025_add_scope_get_splits_caas_tx
Jun 9, 2026
Merged

MON-4025 add caas split get transactions#164
ingridacero merged 1 commit into
mainfrom
MON-4025_add_scope_get_splits_caas_tx

Conversation

@ingridacero

@ingridacero ingridacero commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Description

Adds the caas:transaction_splits:read scope to the caasGetTransactions request so transaction splits are returned by GET /transactions.

The mh-api-gateway only includes the splits array when the access token carries caas:transaction_splits:read. Previously the SDK requested only caas:transactions:read, so splits were always stripped from the response. The request now asks for both scopes. The client-credentials grant filters requested scopes against the client's allow-list and silently drops any it is not registered for, so clients with the splits scope receive splits and clients without it are unaffected (no grant failure, just no splits). No separate method is introduced and the public API surface is unchanged.

Screenshots, Recordings

Screenshot 2026-06-09 at 4 05 35 pm

This PR includes:

  • Unit tests
  • Contract tests
  • Logging
  • Monitoring
  • Dependencies updates
  • Swagger/Documentation changes

Added config changes?

  • Yes, add more details and remember to add them in ETCD
  • No

Added database migrations/resources (db, collection, table, column)?

  • No

Are there any post deployment tasks that need to be performed?

Clients that need splits returned must be registered for the caas:transaction_splits:read scope in identity. No change is required for clients that do not use splits.


Note

Low Risk
Narrow OAuth scope change on an existing CAAS read call with no API signature change; unregistered clients should be unaffected by scope filtering at token grant.

Overview
caasGetTransactions now requests caas:transactions:read and caas:transaction_splits:read on the client-credentials grant (previously only transactions read). The gateway only returns a splits array when the token includes the splits scope, so this fixes split data being omitted for clients that are allowed that scope.

The public method signature is unchanged. Clients not registered for caas:transaction_splits:read should still get tokens without that scope (filtered at grant time) and behave as before. The readme caasGetTransactions section documents both scopes and when splits appear.

Reviewed by Cursor Bugbot for commit b0d2ece. Bugbot is set up for automated code reviews on this repo. Configure here.

@ingridacero ingridacero merged commit 36be4c7 into main Jun 9, 2026
3 checks passed
@ingridacero ingridacero deleted the MON-4025_add_scope_get_splits_caas_tx branch June 9, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant