Introduce subtypes of InvalidArgumentException #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am pretty alone here managing this package, but personally I think this is a good PR. There is no BC-break and I can see why the specific exceptions add value. @ruudk Since you have actively helped getting PHP8.4 support in, would you be willing to provide some feedback? |
ruudk
approved these changes
Mar 28, 2025
UlrichEckhardt
approved these changes
Mar 28, 2025
|
There is a PHPStan error. If someone is able to see what is causing this, and resolve it, I can merge it. Otherwise I will have a look myself, but I don't know exactly when I have time for that. |
|
@frederikbosch #810 may solve the PHPStan error |
|
Now this one can be rebased against current master and then merged. |
renanbr
force-pushed
the
invalid-arg-exception
branch
from
78e1980 to
3fb5ac9
Compare
|
Great, thanks for the work. Nice addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces subtypes of
InvalidArgumentException.This improves the log analysis and allow users to rely on type instead of exception message when handling specific errors.