Mathias's Patch: Perf tuning for gcc + aarch64 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erin2722
force-pushed
the
mathias-perf-tuning
branch
from
911f364 to
90b7d1b
Compare
samanca
reviewed
Feb 6, 2024
| std::memmove(dst + kShortMemCopy, | ||
| static_cast<const uint8_t*>(src) + kShortMemCopy, | ||
| 64 - kShortMemCopy); | ||
| FixedSizeMemMove<kShortMemCopy>( |
There was a problem hiding this comment.
[Q] We've already copied kShortMemCopy bytes on line 1126. This code used to copy the remaining bytes if size > kShortMemCopy by copying 64 - kShortMemCopy bytes. The new code, however, always copies kShortMemCopy, assuming 2 * kShortMemCopy == 64, right? If so, do we need to have a static assertion verifying this?
There was a problem hiding this comment.
It is defined as 32 on line 1100, 30 lines up. Adding a static assert that 32*2 == 64 seems silly. Also the original AVX impl was relying on this as well.
samanca
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
I just have one question for @RedBeard0531, otherwise LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying google#176 to our fork so that we can upgrade with perf benefits now.