chore: remove cjs named exports mimicking esm

configs/testing-library-compass/src/index.tsx

@@ -47,20 +47,30 @@ import {
 } from 'compass-preferences-model/provider';
 import { TelemetryProvider } from '@mongodb-js/compass-telemetry/provider';
 import { CompassComponentsProvider } from '@mongodb-js/compass-components';
+
+/**
+ * NB: we are breaking the rules in this package and importing code directly
+ * from source so that we can create a better unit testing expirience while
+ * avoiding exposing the internals of the connections logic to the rest of the
+ * code in the repo. This is not a pattern that should be used anywhere else in
+ * the codebase!
+ */
 import {
   TestEnvCurrentConnectionContext,
   ConnectionInfoProvider,
-} from '@mongodb-js/compass-connections/src/connection-info-provider';
-import type { State } from '@mongodb-js/compass-connections/src/stores/connections-store-redux';
-import { createDefaultConnectionInfo } from '@mongodb-js/compass-connections/src/stores/connections-store-redux';
-import { getDataServiceForConnection } from '@mongodb-js/compass-connections/src/stores/connections-store-redux';
+} from '../../../packages/compass-connections/src/connection-info-provider';
+import type { State } from '../../../packages/compass-connections/src/stores/connections-store-redux';
+import { createDefaultConnectionInfo } from '../../../packages/compass-connections/src/stores/connections-store-redux';
+import { getDataServiceForConnection } from '../../../packages/compass-connections/src/stores/connections-store-redux';
 import {
   useConnectionActions,
   useStore,
-} from '@mongodb-js/compass-connections/src/stores/store-context';
+} from '../../../packages/compass-connections/src/stores/store-context';
 import CompassConnections, {
   ConnectFnProvider,
-} from '@mongodb-js/compass-connections/src/index';
+} from '../../../packages/compass-connections/src/index';
+/***/
+
 import type {
   CompassPluginComponent,
   CompassPlugin,

packages/atlas-service/package.json

@@ -17,17 +17,12 @@
     "url": "https://github.com/mongodb-js/compass.git"
   },
   "files": [
-    "dist",
-    "main.js",
-    "main.d.ts",
-    "renderer.js",
-    "renderer.d.ts",
-    "provider.js"
+    "dist"
   ],
   "license": "SSPL",
   "exports": {
-    "./main": "./main.js",
-    "./renderer": "./renderer.js",
+    "./main": "./dist/main.js",
+    "./renderer": "./dist/renderer.js",
     "./provider": "./dist/provider.js"
   },
   "compass:exports": {

packages/compass-aggregations/test/configure-store.ts

@@ -73,7 +73,7 @@ function getMockedPluginArgs(
  */
 export default function configureStore(
   ...args: Parameters<typeof getMockedPluginArgs>
-) {
+): any /* TODO: typescript is struggling to infer the types here correctly */ {
   const [Plugin, initialProps, connectionInfo, renderOptions] =
     getMockedPluginArgs(...args);
   const { activatePluginWithActiveConnection } =

packages/compass-app-stores/package.json

@@ -17,9 +17,7 @@
     "url": "https://github.com/mongodb-js/compass.git"
   },
   "files": [
-    "dist",
-    "provider.js",
-    "provider.d.ts"
+    "dist"
   ],
   "license": "SSPL",
   "main": "dist/index.js",

packages/compass-connections/package.json

@@ -17,13 +17,15 @@
     "url": "https://github.com/mongodb-js/compass.git"
   },
   "files": [
-    "dist",
-    "provider.js",
-    "provider.d.ts"
+    "dist"
   ],
   "license": "SSPL",
   "main": "dist/index.js",
   "compass:main": "src/index.tsx",
+  "exports": {
+    ".": "./dist/index.js",
+    "./provider": "./dist/provider.js"
+  },
   "compass:exports": {
     ".": "./src/index.tsx",
     "./provider": "./src/provider.ts"

packages/compass-connections/src/provider.ts

@@ -1,6 +1,11 @@
 import { createServiceLocator } from '@mongodb-js/compass-app-registry';
 import { useConnectionInfo } from './connection-info-provider';
 import type { DataService } from 'mongodb-data-service';
+import type {
+  ConnectionsEventEmitter,
+  ConnectionsEventMap,
+  ConnectionState,
+} from './stores/connections-store-redux';
 import { getDataServiceForConnection } from './stores/connections-store-redux';
 
 export type { DataService };
@@ -87,3 +92,6 @@ const ConnectionStatus = {
 } as const;
 
 export { ConnectionStatus };
+export type { ConnectionId } from './stores/connections-store-redux';
+
+export type { ConnectionsEventEmitter, ConnectionsEventMap, ConnectionState };

packages/compass-connections/src/stores/connections-store-redux.ts

@@ -427,15 +427,21 @@ const ConnectionAttemptForConnection = new Map<
 
 const DataServiceForConnection = new Map<ConnectionId, DataService>();
 
-export function getDataServiceForConnection(connectionId: ConnectionId) {
+export type GetDataServiceForConnectionFn = (
+  connectionId: ConnectionId
+) => DataService;
+
+export const getDataServiceForConnection: GetDataServiceForConnectionFn = (
+  connectionId
+) => {
   const ds = DataServiceForConnection.get(connectionId);
   if (!ds) {
     throw new Error(
       `Failed to locate DataService instance for connection ${connectionId}`
     );
   }
   return ds;
-}
+};
 
 /**
  * Connection secrets are stored in-memory even after disconnecting (even if

packages/compass-connections/src/stores/store-context.tsx

@@ -13,6 +13,7 @@ import {
 import type {
   configureStore,
   ConnectionId,
+  ConnectionsEventEmitter,
   ConnectionState,
   State,
 } from './connections-store-redux';
@@ -209,7 +210,12 @@ export function useConnectionsListRef(): {
   return ref;
 }
 
-function useConnections() {
+export type ConnectionsService = Omit<ConnectionsEventEmitter, 'emit'> & {
+  getDataServiceForConnection: typeof getDataServiceForConnection;
+} & ReturnType<typeof useConnectionsListRef> &
+  ReturnType<typeof useConnectionActions>;
+
+function useConnections(): ConnectionsService {
   const actions = useConnectionActions();
   const connectionsListRef = useConnectionsListRef();
   return useInitialValue({
@@ -218,16 +224,13 @@ function useConnections() {
     getDataServiceForConnection,
     on: connectionsEventEmitter.on,
     off: connectionsEventEmitter.off,
+    once: connectionsEventEmitter.once,
     removeListener: connectionsEventEmitter.removeListener,
   });
 }
 
-export type ConnectionsService = ReturnType<typeof useConnections>;
-
-export const connectionsLocator = createServiceLocator(
-  useConnections,
-  'connectionsLocator'
-);
+export const connectionsLocator: () => ConnectionsService =
+  createServiceLocator(useConnections, 'connectionsLocator');
 
 function isShallowEqual(
   a: Record<string, unknown> | null,

packages/compass-generative-ai/package.json

@@ -17,8 +17,7 @@
     "url": "https://github.com/mongodb-js/compass.git"
   },
   "files": [
-    "dist",
-    "provider.js"
+    "dist"
   ],
   "license": "SSPL",
   "main": "dist/index.js",

packages/compass-logging/package.json

@@ -19,8 +19,7 @@
     "url": "https://github.com/mongodb-js/compass.git"
   },
   "files": [
-    "dist",
-    "provider.js"
+    "dist"
   ],
   "license": "SSPL",
   "main": "dist/index.js",

packages/compass-telemetry/package.json

@@ -17,8 +17,7 @@
     "url": "https://github.com/mongodb-js/compass.git"
   },
   "files": [
-    "dist",
-    "provider.js"
+    "dist"
   ],
   "license": "SSPL",
   "main": "dist/index.js",

packages/connection-storage/package.json

@@ -17,19 +17,13 @@
     "url": "https://github.com/mongodb-js/compass.git"
   },
   "files": [
-    "dist",
-    "main.js",
-    "main.d.ts",
-    "renderer.js",
-    "renderer.d.ts",
-    "provider.js",
-    "provider.d.ts"
+    "dist"
   ],
   "license": "SSPL",
   "exports": {
-    "./main": "./main.js",
-    "./renderer": "./renderer.js",
-    "./provider": "./provider.js"
+    "./main": "./dist/main.js",
+    "./renderer": "./dist/renderer.js",
+    "./provider": "./dist/provider.js"
   },
   "compass:exports": {
     "./main": "./src/main.ts",

packages/my-queries-storage/package.json

@@ -17,14 +17,14 @@
     "url": "https://github.com/mongodb-js/compass.git"
   },
   "files": [
-    "dist",
-    "provider.js"
+    "dist"
   ],
   "license": "SSPL",
   "main": "dist/index.js",
   "compass:main": "src/index.ts",
   "exports": {
     ".": {
+      "types": "./dist/index.d.ts",
       "import": "./dist/.esm-wrapper.mjs",
       "require": "./dist/index.js"
     },