-
Notifications
You must be signed in to change notification settings - Fork 271
fix(aggregations): $rerank bug bash changes COMPASS-10696 #8117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
cf8e31e
add token usage link and banner
DarshanaVenkatesh f379dc2
Merge branch 'main' into COMPASS-10696
DarshanaVenkatesh 5265a46
render as buttons instead of links
DarshanaVenkatesh bbde173
Merge branch 'main' into COMPASS-10696
DarshanaVenkatesh 47d25d3
remove style ts file
DarshanaVenkatesh 4f5e403
update url
DarshanaVenkatesh 98b18b6
update e2e
DarshanaVenkatesh 0b9ce71
Merge branch 'main' into COMPASS-10696
DarshanaVenkatesh 31d54e0
make url builder generic
DarshanaVenkatesh 94a0d42
Merge branch 'main' into COMPASS-10696
DarshanaVenkatesh e537cd8
close focus mode before ai assistant
DarshanaVenkatesh 94fd0da
remove rerank consumes token banner
DarshanaVenkatesh 51c5992
Merge branch 'main' into COMPASS-10696
DarshanaVenkatesh 480ea38
update to dochub link
DarshanaVenkatesh 9721b2e
Merge branch 'main' into COMPASS-10696
DarshanaVenkatesh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
packages/compass-aggregations/src/components/banner-button-styles.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import { css } from '@mongodb-js/compass-components'; | ||
|
|
||
| // Shared styling for action buttons rendered inside banners. Keeps the label | ||
| // contained on a single line within the button, and removes the underline that | ||
| // the Banner applies to descendant anchors (a Button with an `href` renders as | ||
| // an `<a>`). The `:any-link` selector is needed to outweigh the Banner's own | ||
| // `a` rule. | ||
| export const bannerButtonStyles = css({ | ||
| flexShrink: 0, | ||
| whiteSpace: 'nowrap', | ||
| '&:any-link': { | ||
| textDecorationLine: 'none', | ||
| }, | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we convert this to an object? Something like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, open to making this generic. updated!