feat(aggregations): add search activation p2 debug button to $search error banner #8146
Draft
DarshanaVenkatesh wants to merge 11 commits into
Draft
feat(aggregations): add search activation p2 debug button to $search error banner #8146DarshanaVenkatesh wants to merge 11 commits into
DarshanaVenkatesh wants to merge 11 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR integrates the Compass Assistant with the aggregations server error banner to provide an in-product “Debug” entry point for $search stage failures, by wiring stage context + error details into a new proactive-insights prompt.
Changes:
- Adds a new proactive-insights context (
aggregation-pipeline-error) and prompt for diagnosing aggregation pipeline failures. - Adds a “Debug” button to the aggregations server error banner for
$searcherrors that forwards stage context to the Assistant (and closes focus mode first). - Exposes
AssistantActionsContextfrom the assistant package entrypoint and adds component-level tests for the new debug button behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/compass-assistant/src/prompts.ts | Adds a new proactive-insights context + prompt for aggregation pipeline errors. |
| packages/compass-assistant/src/index.tsx | Re-exports AssistantActionsContext for consumption outside the assistant package (tests/consumers). |
| packages/compass-aggregations/src/components/stage-editor/stage-editor.tsx | Passes stage context and focus-mode close handler down to the error banner. |
| packages/compass-aggregations/src/components/server-error-banner.tsx | Renders the “Debug” button for $search errors and triggers Assistant insight flow. |
| packages/compass-aggregations/src/components/server-error-banner.spec.tsx | Adds coverage for debug button visibility and click behavior. |
032122f to
b844d9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes