feat(crud): show object elements in document view COMPASS-6707#8167
Open
mabaasit wants to merge 9 commits into
Open
feat(crud): show object elements in document view COMPASS-6707#8167mabaasit wants to merge 9 commits into
mabaasit wants to merge 9 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds first-pass UI support for displaying embedded object values in the document view by providing an Object-specific renderer and wiring document-list elements to supply a renderable “original value” for object fields.
Changes:
- Extend document-list element model to derive an
originalValueforObjecttypes (in addition to arrays/primitives). - Add an
ObjectValuerenderer toBSONValueand routetype: 'Object'through it.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/compass-components/src/components/document-list/element.tsx |
Derives/passes an originalValue suitable for rendering object elements in the document list. |
packages/compass-components/src/components/bson-value.tsx |
Introduces an ObjectValue renderer and uses it for BSON Object types. |
Anemy
changed the title
| // Otherwise use default sort method based on the value type | ||
| if (typeof a[name] === 'string') { | ||
| return sortString(a[name] as string, b[name] as string, order); | ||
| return sortString(a[name], b[name] as string, order); |
Collaborator
There was a problem hiding this comment.
Is there a reason why the first argument cast was removed but the second was kept?
alenakhineika
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Draft because waiting for design feedback.
Preview
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes