Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies npm pkg fix-style manifest normalization and dependency key ordering across the monorepo, and adds CI enforcement to keep package.json dependency sections consistently sorted for easier dependency-upgrade reviews.
Changes:
- Normalize
repository.urlfields to npm’s canonicalgit+https://...form across packages/configs. - Normalize/sort manifest entries (notably dependency key ordering; plus some
binpath normalization). - Update CI to use a dedicated test-group computation script and add a lint job that fails if dependency keys become unsorted.
Reviewed changes
Copilot reviewed 38 out of 39 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/package.json | Normalize repository URL and keep devDependency keys sorted. |
| packages/ts-autocomplete/package.json | Normalize repository URL. |
| packages/tracking-plan/package.json | Normalize repository URL. |
| packages/signing-utils/package.json | Normalize repository URL and sort dependency keys. |
| packages/shell-bson-parser/package.json | Normalize repository URL. |
| packages/sbom-tools/package.json | Normalize bin path and repository URL. |
| packages/saslprep/package.json | Normalize repository URL. |
| packages/query-parser/package.json | Normalize repository URL and sort dependency keys. |
| packages/oidc-mock-provider/package.json | Normalize repository URL. |
| packages/oidc-http-server-pages/package.json | Normalize repository URL and clean/sort dependency sections. |
| packages/node-webpack-startup-snapshot-checker/package.json | Normalize repository URL. |
| packages/native-machine-id/package.json | Normalize repository URL and sort devDependency keys. |
| packages/mql-typescript/package.json | Normalize repository URL. |
| packages/monorepo-tools/package.json | Normalize repository URL and bin paths. |
| packages/mongodb-ts-autocomplete/package.json | Normalize repository URL. |
| packages/mongodb-server-log-checker/package.json | Normalize repository URL. |
| packages/mongodb-runner/package.json | Normalize repository URL. |
| packages/mongodb-redact/package.json | Normalize repository URL and sort dependency keys. |
| packages/mongodb-ns/package.json | Normalize repository URL. |
| packages/mongodb-log-writer/package.json | Normalize repository URL. |
| packages/mongodb-downloader/package.json | Normalize repository URL and sort dependency/devDependency keys. |
| packages/mongodb-constants/package.json | Normalize repository URL. |
| packages/mongodb-cloud-info/package.json | Normalize repository URL. |
| packages/mongodb-build-info/package.json | Normalize repository URL. |
| packages/get-os-info/package.json | Normalize repository URL. |
| packages/download-url/package.json | Normalize repository URL and sort devDependency keys. |
| packages/dl-center/package.json | Normalize repository URL and sort devDependency keys. |
| packages/devtools-proxy-support/package.json | Normalize repository URL and sort dependency keys. |
| packages/devtools-connect/package.json | Normalize repository URL. |
| packages/device-id/package.json | Normalize repository URL. |
| packages/aggregation-stage-icons/package.json | Normalize repository URL. |
| configs/tsconfig-devtools/package.json | Normalize repository URL. |
| configs/prettier-config-devtools/package.json | Normalize repository URL. |
| configs/mocha-config-devtools/package.json | Normalize repository URL. |
| configs/eslint-plugin-devtools/package.json | Normalize repository URL. |
| configs/eslint-config-devtools/package.json | Normalize repository URL. |
| .github/workflows/check-test.yaml | Point test grouping to .github/scripts/compute-test-group.mjs and add a lint job enforcing sorted dependency keys. |
| .github/scripts/lint-pkg.mjs | Add CI script to validate sorted dependency keys across package.json files. |
| .github/scripts/compute-test-group.mjs | Add script to compute stable, round-robin test scopes per CI group. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mabaasit
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
npm pkg fix runs the same auto correct that happens during publish. Running it here so our package.json in git and in npm can be more ===
Also sort deps and prevents them from being unsorted, this helps reviewing dep upgrades because you won't also have to account for deps jumping around as their ordering gets fixed
Open Questions
Do we want this in other repos? Yes, but devtools-shared probably benefits more than other repos, just because its a very shared responsibility, making dep bumps easy to review can make us all work a little faster
Checklist