fix/COMPASS-9961 make sure id is not silently swallowed on the Field component#155
Merged
gribnoysup merged 2 commits intomainfrom Oct 15, 2025
Merged
fix/COMPASS-9961 make sure id is not silently swallowed on the Field component#155gribnoysup merged 2 commits intomainfrom
gribnoysup merged 2 commits intomainfrom
Conversation
gribnoysup
force-pushed
the
COMPASS-9961
branch
from
4fa9e8e to
8f88101
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External Links
Description
Recent regression caused by fixing the key prop on the Field component. Made the types on Field component stricter and added a test to make sure this doesn't break in the future
Notes for Reviewers
n/a
📸 Screenshots/Screencasts
n/a