feat/COMPASS-9799 Add support to change field type#160
Merged
Conversation
| return ( | ||
| <ObjectTypeContainer> | ||
| {'{}'} | ||
| <span title="object">{'{}'}</span> |
Collaborator
There was a problem hiding this comment.
ah, thanks for adding the titles as well!
Collaborator
|
The select closes when I go away (select another field), but is opened after I come back to the field (by clicking on the name) Screen.Recording.2025-10-27.at.19.43.24.mov |
Collaborator
|
Eeek, maybe the LG select isn't made for draggable elements 😅 Screen.Recording.2025-10-27.at.19.51.14.mov |
paula-stacho
approved these changes
Nov 12, 2025
Collaborator
paula-stacho
left a comment
paula-stacho
left a comment
There was a problem hiding this comment.
Looks good! Let's get this in 🎉
… feature/COMPASS-9799-editable-field-type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External Links
Description
In this PR, I added an option to allow changing field types. The list of supported field type will be injected via
EditableDiagramInteractionsProvideralong withonFieldTypeChange.I am using LG Select to show the list of field types. As LG Select does not allow to override the trigger, I am hiding the select button and manually controlling select.
Notes for Reviewers
📸 Screenshots/Screencasts
After
Screen.Recording.2025-10-26.at.19.44.10.mov