fix(NODE-6795): support build-from-source installs#127
Open
axelonet wants to merge 1 commit intomongodb-js:mainfrom
Open
fix(NODE-6795): support build-from-source installs#127axelonet wants to merge 1 commit intomongodb-js:mainfrom
axelonet wants to merge 1 commit intomongodb-js:mainfrom
Conversation
addaleax
reviewed
Mar 16, 2026
Collaborator
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
This looks pretty good, I don't think it needs to be a draft?
etc/utils.mjs
Outdated
| if (ref.includes('.')) { | ||
| const [major, minor] = ref.split('.'); | ||
| const branch = `r${major}.${minor}`; | ||
| return `https://mciuploads.s3.amazonaws.com/libmongocrypt-release/${platform}/${branch}/${hash}/libmongocrypt.tar.gz`; |
Collaborator
There was a problem hiding this comment.
Can we keep the comments from the original files?
Author
There was a problem hiding this comment.
Sure thing! Thanks a lot for looking into the Drafts ^_^
I've raised a similar PR to the sister repo here: mongodb-js/zstd#110
Just wanted to make sure if anything pops over there as this is related.
Will move it from Draft now.
axelonet
force-pushed
the
NODE-6795-build-from-source-libmongocrypt
branch
from
b33b7a9 to
ae8c1ea
Compare
dariakp
added
External Submission
|
@axelonet , thanks so much for your contribution. The team will triage this PR and https://jira.mongodb.org/browse/NODE-6795 and will get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Support
npm install mongodb-client-encryption --build-from-sourceby bootstrappinglibmongocryptbeforenode-gyp rebuildMoved libmongocrypt bootstrap helpers to
etc/and use them consistently in both published installs and repo workflowsNotes for Reviewers
npm install mongodb-client-encryption --build-from-sourcefatal error: 'mongocrypt/mongocrypt.h' file not foundnpm packand verified the helper files are included in the tarballnpm install /mongodb-client-encryption/mongodb-client-encryption-7.0.0.tgz --build-from-sourceRelease Highlight
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript